Trunk: unresolved symbols

VERIFIED FIXED

Status

SeaMonkey
General
P3
major
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Jim Dunn, Assigned: Jim Dunn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

17 years ago
A recent change to config/rules.mk (rev 3.2.54), caused a problem
with HP building mozilla-bin.  nsMPFileLocProvider::nsMPFileLocProvider()
and nsAppFileLocationProvider::nsAppFileLocationProvider()
which are found in libxpfelocation_s.a & libmpfilelocprovider_s.a.
However because the the 'needed' change to rules.mk the SHARED_LIBRARY_LIBS
are no longer being included.

So my suggested fix is: Chris, what do you think?

Index Makefile.in
=================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v
retrieving revision 1.103
diff -u -r 1.103 Makefile.in
--- Makefile.in 2000/11/20 07:15:42    1.103
+++ Makefile.in 2000/11/28 22:04:14
@@ -35,13 +35,9 @@
 PROGRAM                 = mozilla-bin
 endif

-EXTRA_DSO_LIBS = gkgfx
-
-ifeq ($MOZ_WIDGET_TOOLKIT),os2)
-EXTRA_DSO_LIBS += xpfelocation_s mpfilelocprovider_s
-else
-SHARE_LIBRARY_LIBS = -lxpfelocation_s -lmpfilelocprovider_s
-endif
+EXTRA_DSO_LIBS = gkgfx \
+               xpfelocation_s mpfilelocprovider_s \
+               $(NULL)

 CPPSRCS
(Assignee)

Comment 1

17 years ago
updating...
Blocks: 18687
QA Contact: doronr → barrettl
Summary: unresolved symbols → Trunk: unresolved symbols
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED

Comment 2

17 years ago
Looks good to me. r=cls
(Assignee)

Comment 3

17 years ago
Adding mike since I am removing his ifdef,
and basically using his makefile path for all platforms.

Comment 4

17 years ago
The patch has been checked in.  Marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 5

17 years ago
Oooh, this fixed part of the OpenBSD build problems as well.

Updated

16 years ago
Status: RESOLVED → VERIFIED

Comment 6

16 years ago
verified
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.