613923 - Can not bookmark by drag & drop a link, if <br> includes in linktext.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101121 Firefox/4.0b8pre ID:20101121044503

Can not add bookmark by drag & drop a link, if <br> includes in linktext.

<a href="https://bugzilla.mozilla.org/">Bugzilla<br>Mozilla –<br> Main Page</a>
<a href="https://bugzilla.mozilla.org/">Bugzilla<br>Mozilla – Main Page</a>

On the other hand, "Bookmark This Link" of context-menu is successfully performed.

Reproducible: Always

Steps to Reproduce:
1. Start minefield with new profile
2. open URL
3. Drag and drop onto Bookmarks Toolbar/Menu/Sidebar

Actual Results:
 Can not bookmark.
 Error in the Error console:
   Error: dragged is undefined
   Source file: chrome://browser/content/places/controller.js
   Line: 1431

>> if (dragged.type == PlacesUtils.TYPE_X_MOZ_PLACE_CONTAINER ||
      /^place:/.test(dragged.uri)) {

Expected Results:
 Bookmarking should be successfully performed by D&D.

Comment 1

[Marco Bonardo [:mak]]

is this a recent regression?

Comment 2

[Alice0775 White]

(In reply to comment #1)
> is this a recent regression?

Not a recent.
It regressed between Firefox2.0.0.x and Firefox3.0.x .

Works on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.8.1.22pre) Gecko/20090415 Firefox/2.0.0.22
Not work on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.0.19) Gecko/2010031422 Firefox/3.0.19

Comment 3

[Marco Bonardo [:mak]]

ok, thanks.
it's a nice to have, probably not hard to fix, harder to test maybe.

Comment 4

[chado]

I'm seeing this on Windows XP SP3 and Linux (Ubuntu 10.10 on VirtualBox Guest VM)
using Firefox-trunk and SeaMonkey-trunk.

Additionally, there are some similar cases without br in linked text,
but from the list items, existing on trunk only.  
I filed Bug 624991 for that.

Comment 5

[Mark Banner (:standard8)]

I've just tried this on FF 60.0 nightly on Mac and it all works fine. I guess this got fixed along the way somewhere.