613979 - oninput should fire after the validity state update

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

For the moment, the validity states, when the user is typing, is updated after oninput fires. We can imagine that a lot of scripts will try to use oninput to play with validity.
That would be very bad to ship with this behavior.

Presto and Webkit fires oninput after the validity state update.

Testcase: open url, type in the input field. You should see "true", with current trunk, you will see "false".

Comment 1

[Mounir Lamouri (:mounir)]

Should be blocking. See comment 0.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

So form elements could check the validity in PreHandleEvent when trusted input 
event is dispatched?

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> So form elements could check the validity in PreHandleEvent when trusted input 
> event is dispatched?

Actually, the fix is simple: we just need to switch FireOnInput and OnValueChanged calls [1]. However, I'm wondering if doing the validity state in PreHandleEvent wouldn't have been better?

[1] http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsTextEditorState.cpp#883

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 5

[Johnny Stenback (:jst)]

Blocking per Mounir's original comment.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/14f1f60c6a11