614124 - Can't change urls for feedback add-on to test changes on staging

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

It's not possible to test staging changes for device type since the URLs are hard-coded into the button xul line. Can we get them changed into prefs just like the desktop firefox feedback add-on code?

Pref names and values: https://github.com/mozilla/testpilot/blob/master/extension/defaults/preferences/preferences.js#L22

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Fix

Is it just these two urls?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 492523 [details] [diff] [review]
Fix

># HG changeset patch
># User Wes Johnston <[e-mail]>
># Parent 7a1fe06d33afc77d20e41f4c71242ca0b01c4989
>Bug 614124 - Store Feedback urls as prefs.
>
>diff --git a/app/profile/extensions/[e-mail]/content/overlay.js b/app/profile/extensions/[e-mail]/content/overlay.js
>--- a/app/profile/extensions/[e-mail]/content/overlay.js
>+++ b/app/profile/extensions/[e-mail]/content/overlay.js
>@@ -67,19 +67,24 @@ var Feedback = {
>       Feedback._manufacturer = sysInfo.get("manufacturer");
> 
>       // XXX Simple debugging. Remove when tested
>       Services.console.logStringMessage("Device: " + Feedback._device);
>       Services.console.logStringMessage("Manufacturer: " + Feedback._manufacturer);
>     }, false);
>   },
> 
>-  openFeedback: function(aURL) {
>+  openFeedback: function(aUrlName) {

aName

>+    let pref = "extensions.input." + aUrlName;

"extensions.feedback."

I can tweak and land

Comment 3

[Aakash Desai [:aakashd]]

Yeah, its just those two. Thanks for the quick turnaround guys. I owe you some lunch wesj (and you too Mark, when you're in mv).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/576c14b07c7c

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101123 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101123 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 6

[Dão Gottwald [:dao]]

bugspam