614162 - Do more check in gBrowser.moveTabTo

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101122 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101122 Firefox/4.0b8pre

In trunk, gBrowser.moveTabTo now checks whether aIndex == aTab._tPos before it goes. But if aIndex falls out of [0, gBrowser.mTabs.length - 1], it still goes. This will lead to improper behavior.

Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Can you give an URL to the code in question?

Comment 2

[ithinc]

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#1983

1988           var oldPosition = aTab._tPos;
1989           if (oldPosition == aIndex)
1990             return;

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

As far as I can see we never have checked for the correct bounds in this method. Dao, could you please give a feedback on it?

Comment 4

[ithinc]

Fx3.6 doesn't check "oldPosition == aIndex", but Fx4 does. It should check more like gBrowser.selectTabAtIndex.