Drop unnecessary NECKO_PROTOCOLS_DEFAULT in confvars.sh

RESOLVED FIXED in Thunderbird 3.3a2

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Thunderbird 3.3a2
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 492606 [details] [diff] [review]
The fix

http://mxr.mozilla.org/comm-central/search?string=NECKO_PROTOCOLS_DEFAULT

iirc we used to specify this so we didn't build in things like gopher. However that changed, and there's nothing specific we don't want. In addition, the recently added wyciwyg is not getting built into the build, and this breaks IPC builds of Thunderbird (which I'm working towards).

So I think we should just remove it and use the same that mozilla-central uses.

Also, I'm removing the define for Sunbird just to get it out of the way when searching.
Attachment #492606 - Flags: review?(bugspam.Callek)
Comment on attachment 492606 [details] [diff] [review]
The fix

Code-Change is good. I don't consider myself qualified [with TB team/plans] on the "do we want this" but you are, and I have no objections based on your reasoning.
Attachment #492606 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 2

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/b91fd1c9b44e
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Assignee: nobody → bugzilla
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.