Closed
Bug 614305
Opened 14 years ago
Closed 14 years ago
Cannot localize string "Firefox Support" in the title of page
Categories
(support.mozilla.org :: Localization, task)
support.mozilla.org
Localization
Tracking
(Not tracked)
VERIFIED
FIXED
2.4.3
People
(Reporter: JasnaPaka, Assigned: jsocol)
References
()
Details
1) Visit https://support-stage-new.mozilla.com/cs/kb/Aktualizace%20Firefoxu/discuss
2) See page title. There is "Diskuse Aktualizace Firefoxu | Databáze znalostí | Firefox Support".
I think we should have ability to translate string "Firefox Support".
Assignee | ||
Comment 1•14 years ago
|
||
Ah, it's using _lazy but _lazy doesn't appear to support msgctxt.
Summary: [Kitsune] Cannot localize string "Firefox Support" in the title of page → Cannot localize string "Firefox Support" in the title of page
Comment 2•14 years ago
|
||
Adding to that, it should actually be called "Firefox Help" (as we call the site everywhere else). Too late for that now? Or do we already have that string in Verbatim and we can just switch?
Assignee | ||
Comment 3•14 years ago
|
||
We already have the string "Firefox Help" so we should be good there.
Comment 4•14 years ago
|
||
Cool - thanks!
Comment 5•14 years ago
|
||
Fixed?
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Fixed?
Unless the string has recently appeared in Verbatim, no, this bug is accurate. Moving into 2.4.3, since it should be quick.
(In reply to comment #1)
> Ah, it's using _lazy but _lazy doesn't appear to support msgctxt.
Let me clarify this a bit: _lazy() *does* support msgctxt, but we have its format set wrong so Tower doesn't know it accepts msgctxt.
Component: Knowledge Base Software → Localization
QA Contact: kb-software → localization
Target Milestone: --- → 2.4.3
Comment 7•14 years ago
|
||
> Unless the string has recently appeared in Verbatim, no, this bug is accurate.
> Moving into 2.4.3, since it should be quick.
It is in Verbatim for a long time:
https://localize.mozilla.org/fr/sumo/translate.html?unit=718457
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → james
Assignee | ||
Comment 8•14 years ago
|
||
https://github.com/jsocol/kitsune/commit/b7fb1da
Everything I said in comment 1, comment 3, and comment 6 was wrong.
Here's the real problem:
Strings can't be extracted from settings.py, which is where the string was. Strings only get extracted from an app. Putting the string into an app for no reason other than to get it localized essentially breaks making it a setting, anyway. So now it's just in the templates.
We have the string, but this version has context, since it's the site title. It should show up on Verbatim when we update for 2.4.3 strings. (Probably Friday.)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 9•14 years ago
|
||
Unable to verify until this has been localized. Closing as verified to get it out of the queue- please re-open if this issue persists.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•