614496 - Form assistant and autocomplete bar are separated by a light grey line.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101117 Firefox/4.0b8pre
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101123 Firefox/4.0b8pre Fennec /4.0b3pre

There is a light grey line between the form assistant and the autocomplete bar when you scroll down to the end of the page. 

Reproducible: Always

Steps to Reproduce:
1.Visit http://bugzilla.mozilla.org
2.Type "twitter" in the Quick Search bar so that the autocomplete bar appears.
3.Scroll down till you reach the end of the page.
Actual Results:  
You will see that, when you reach the end of the page, the form assistant detaches itself from the autocomplete bar and a light grey line appears between the two of them.

see the attached screenshot 

Expected Results:  
The form assistant should not detach itself from the autocomplete bar.

Comment 1

[Anna (Waverley)]

Attachment: The Actual Result

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's the content page showing through; may be the same thing with bug 606019?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This happens because the UI is too big to fit on the screen, and so we need to have smaller buttons on the right sidebars. This patch changed the size of those elements to a better one.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 493279 [details] [diff] [review]
Patch

70px is ok by me. We were using 64px before the theme change. I am worried about the impact of sidebars in general. What if an add-on adds some buttons? I assume we would be in trouble again?

We should think about a general solution for this.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I am CC'ing Madhava so he is a aware of this change.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> Comment on attachment 493279 [details] [diff] [review]
> Patch
> 
> 70px is ok by me. We were using 64px before the theme change. I am worried
> about the impact of sidebars in general. What if an add-on adds some buttons? I
> assume we would be in trouble again?

yes :/

Comment 7

[Tony Chung [:tchung]]

Attachment: tab sidebar screenshot

vkb and find in page tends to fire up the tab sidebar as well.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d0f80dc4d015

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101210 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 10

[Dão Gottwald [:dao]]

bugspam