Closed Bug 614504 Opened 14 years ago Closed 12 years ago

configure.in has broken link for MDC altbase.h article

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 669829

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(1 file)

configure.in has two copies of this line:
> AC_MSG_ERROR([System header atlbase.h is not available. See org/en/docs/atlbase.h">http://developer.mozilla.org/en/docs/atlbase.h for details on fixing this problem.])

The URL given there is broken, though -- the correct URL is:
  https://developer.mozilla.org/en/atlbase.h
There's a similar problem with another line in configure.in for https://developer.mozilla.org/en-US/docs/oleacc.idl that really wants https://developer.mozilla.org/en/oleacc.idl
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Lets use this bug to patch m-c.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Here is a patch against mozilla-central.
Attachment #493095 - Flags: review?(bugspam.Callek)
Comment on attachment 493095 [details] [diff] [review]
Fixing broken /docs links

I can't officially review m-c code. But it does look good.
Attachment #493095 - Flags: review?(khuey)
Attachment #493095 - Flags: review?(bugspam.Callek)
Attachment #493095 - Flags: feedback+
Depends on: 614663
Blocks: 613103
Comment on attachment 493095 [details] [diff] [review]
Fixing broken /docs links

Everything looks good except the string changes.  Bringing in Pike to decide whether we can change the strings or whether we need to punt that till after the branch.
Attachment #493095 - Flags: review?(l10n)
Attachment #493095 - Flags: review?(khuey)
Attachment #493095 - Flags: review+
Comment on attachment 493095 [details] [diff] [review]
Fixing broken /docs links

I'm missing a few things here:

- a stable API to link into MDN/MDC. We're struck by this at a few points. Preferably a locale-independent link. Do we have a bug for that?
- the targets of those links are already redirects to https.
- js reference moved

If we're doing such a massive change, we should do it right, IMHO.
Attachment #493095 - Flags: review?(l10n) → review-
Our source code is English, I don't think we need locale-independent links here.
We seem to have gotten rid of the link to atlbase.h a while back.
Status: REOPENED → RESOLVED
Closed: 14 years ago12 years ago
Resolution: --- → INVALID
yup, looks like bug 669829 removed this chunk.

Duping to that bug, since the original issue here was "omg broken link" and bug 669829 fixed that (by removing the link). :)
Resolution: INVALID → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: