614593 - Redirect old login/logout/register/etc pages to Kitsune

Status: VERIFIED FIXED

(support.mozilla.org :: Users and Groups, task, P1)

Description

[James Socol [:jsocol, :james]]

Should just need to modify a few .htaccess rules to get

^tiki-login => /users/login
^tiki-logout => /users/logout
^tiki-register => /users/register
^tiki-change_password => /users/<something>
^tiki-user_information => /users/<>/profile*
^tiki-user_preferences => /users/something

Can also drop many of the remaining "keep Tiki working" rewrites like

RewriteRule ^tiki-show_user_avatar.php - [L,QSA]
RewriteRule ^tiki-admin - [L,QSA]
RewriteRule ^tiki-register - [L,QSA]
RewriteRule ^tiki-aaq_modal.php - [L,QSA]
RewriteRule ^tiki-error.php - [L,QSA]
RewriteRule ^tiki-random_num_img.php - [L,QSA]
RewriteRule ^minify.php - [L,QSA]
RewriteRule ^styles - [L,QSA]
RewriteRule ^pics - [L,QSA]
RewriteRule ^img - [L,QSA]



* Not sure about this, how to get to the correct destination. May just drop.

Comment 1

[James Socol [:jsocol, :james]]

Attachment: wip v1

Not sure what to do with preferences and profiles yet, but this will get you started.

Comment 2

[James Socol [:jsocol, :james]]

Attachment: push almost everything to kitsune

So, what did I do here?

* Removed all the pass-through rewrites that were doing nothing but supporting Tiki logins. (/minify.php, /img/, /tiki-random_num_thing.php, etc) There were a lot!
* Left the two static files, until their functionality can be uplifted into Django.
* Redirect the pages I can (tiki-login, tiki-logout, etc) to logical targets.
* Any other tiki-* URLs are now 404s. I don't redirect them anywhere. Update your bookmarks. (Left a comment in explaining it.)
* Removed a bunch of redundant or unnecessary redirects about locales. Kitsune pretty much does this on its own, so no need to replicate the functionality here. I tested these and they still end up in the right spot, even if the redirect chain is different.

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 496624 [details] [diff] [review]
push almost everything to kitsune

(In reply to comment #2)
> * Any other tiki-* URLs are now 404s. I don't redirect them anywhere. Update
> your bookmarks. (Left a comment in explaining it.)
Do we want to update our 404 page on kitsune to explain to our users wth their favorite pages are gone?

Otherwise this looks good to me.

Comment 4

[James Socol [:jsocol, :james]]

(In reply to comment #3)
> Do we want to update our 404 page on kitsune to explain to our users wth their
> favorite pages are gone?

Maybe. It's probably worth looking at our 404 rate, but that's a separate bug. Also, we care more about someone coming to /forum/1 than about someone coming to /tiki-whatever.php, and we redirect most/all of those.

r79069.

Comment 5

[Rebecca Billings [:rbillings]]

Redirects only on tiki-login, all others give page not found. If that's a non-issue then say so and I'll mark this as verified.

https://master.support.mozilla.com/en-US/tiki-logout_scr.php
https://master.support.mozilla.com/en-US/tiki-change_password.php
https://master.support.mozilla.com/en-US/tiki-user_information.php
https://master.support.mozilla.com/en-US/tiki-user_preferences.php

Comment 6

[James Socol [:jsocol, :james]]

(In reply to comment #5)
> https://master.support.mozilla.com/en-US/tiki-logout_scr.php
> https://master.support.mozilla.com/en-US/tiki-change_password.php
> https://master.support.mozilla.com/en-US/tiki-user_information.php
> https://master.support.mozilla.com/en-US/tiki-user_preferences.php

Can I ask how you got to any of these URLs? They all have the locale in them which, yes, means they should be 404s, but I'm curious about the path you took.

Comment 7

[Rebecca Billings [:rbillings]]

I believe I was at the site [ex: logged in on master] and instead of clicking logout, I added the tiki-logout_scr.php to the url. I also tried it be just adding the full url into the browser.  If there's an alternate way to test these url that will generate a redirect, let me know.

Comment 8

[James Socol [:jsocol, :james]]

Remember when entering "tiki-"-prefixed URLs not to include the locale (e.g. /tiki-logout.php, not /en-US/tiki-logout.php). None of these ever worked with a locale prefix.

> /tiki-logout_scr.php

Doesn't exist, and never has, afaik. "/tiki-login_src.php" does (for some reason) and that redirects correctly for me, as do "/tiki-login.php" and "/tiki-logout.php".

> /tiki-change_password.php

Never intended to redirect this. "/tiki-remind_password.php" was the old "I forgot my password" page, and it redirects for me.

> /tiki-users_preferences.php

WFM (goes to /users/edit) without the locale prefix.

> /tiki-user_information.php

Never intended to redirect this. This is the Tiki equivalent of a user's profile, but because the user ID was in the query string, Apache Rewrites are ill-equipped to redirect it.