614642 - HTTP Auth Prompt failure

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

"Method not implemented" when calling [nsIAuthPrompt2::asyncPromptAuth]

Some kind of regression

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #0)
> "Method not implemented" when calling [nsIAuthPrompt2::asyncPromptAuth]

This is not the problem. This is expected:

http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#955

This code calls aysncPromptAuth and it fails, so the sync fallback is used. The
fallback works, a dialog is displayed and the credentials are filled in.

However, we keep calling nsHttpChannelAuthProvider::PromptForIdentity - I don't
know why yet.

Comment 2

[Alon Zakai (:azakai)]

Auth prompts appear to work fine for me on Linux - or is this indeed just limited to OS X (as stated)?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I see it on desktop Linux. Not sure what Stuart is using.

Comment 4

[Doug Turner (:dougt)]

I see the assertion without a doubt on android or linux, however the prompt still works for me.  I tried both with a sync'ed profile and a clean profile.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> I see the assertion without a doubt on android or linux, however the prompt
> still works for me.  I tried both with a sync'ed profile and a clean profile.

Yeah, the assertion is expected and is not the problem.

Comment 6

[Doug Turner (:dougt)]

yeah, either way, it seems to work fine for me.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Using a nightly on Android (nexus one), I am able to log into Mozilla HTTP basic auth sites. I am still unable to log into the sites using a desktop Linux build.

Comment 8

[Aakash Desai [:aakashd]]

This works for me on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101201 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101201 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre Fennec/4.0b3pre

Comment 9

[Doug Turner (:dougt)]

okay.

so, if you have a username+password saved in your profile, we will try to use this pair and never asked again. It doesn't matter if you have the correct username/password pair or a bad one.... we just use it.

The reason is that if we have a saved username and passwords for a realm, we return it from our prompting code here:

http://mxr.mozilla.org/mobile-browser/source/components/PromptService.js#595

This is quite different than what Firefox does.  Firefox desktop always displays a dialog.  IFF you agree to the prompt, do we log you in.

I think we should follow the same pattern -- at least for beta3.  If we want to discuss alternative methods to log into a site, we can have that discussion somewhere else.

To fix this bug for beta 3, we just need to remove that |return true| statement mention above.

Comment 10

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 11

[Doug Turner (:dougt)]

ignore comment at the end of the patch... blah

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 494789 [details] [diff] [review]
patch v.1


>   asyncPromptAuth: function asyncPromptAuth(aChannel, aCallback, aContext, aLevel, aAuthInfo) {
>     // bug 514196
>+    // This will for the prompt to be sync (even if there is an assertion)
>     throw Cr.NS_ERROR_NOT_IMPLEMENTED;
>   }

Make the comment english or remove it

Comment 13

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/1bf399f3abd1

Comment 14

[Aakash Desai [:aakashd]]

Nice, verified FIXED On builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101203 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101203 Namoroka/4.0b8pre Fennec/4.0b3pre