Created attachment 493116 [details] screenshot Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:184.108.40.206) Gecko/20101026 Firefox/3.6.12 steps to reproduce: 1. Load https://addons.allizom.org/z/en-US/developers/addon/submit/1 2. Accept agreement and move to step#2 3. Upload a search tool(.xml file) observed behavior: .xml files fail the validation with "The package is not of a recognized type" I was able to upload the same search-tool in remora, with no errors.
Jeff, is this something you were working on?
No, validation comes prior to the upload stuff I'm working on.
Matt, do you know if the validator supports search tools?
The validator supports search engines...not really sure if there's a difference from search tools. If they are the same thing, I'll need to see the XML file.
Not really sure why you're getting "The package is not of a recognized type", my builds show "The provided MIME type (application/x-suggestions-json) is not acceptable". I updated the validator to simply skip any <Url /> elements that have invalid MIME types rather than failing on them...I wouldn't doubt that folks will extend on the spec (as in this case) in the future. https://github.com/mattbasta/amo-validator/commit/f24d366e1a07bc9b4a9e0416563bc7fa3c1d55fe Kumar: You might want to make this one dependent on bug 614575 as well.
oh, this was actually a simpler fix. Our upload code wasn't recognizing xml files. Fixed as of https://github.com/jbalogh/zamboni/commit/2503f106d58c37a003998b5a7b7b2b162a4aa849
update: There was a bug where uploading this search tool caused unwanted messages to display. Fixed in https://github.com/jbalogh/zamboni/commit/492e7f6361038f874c5a622b8196ae61066c78df
verified fixed by uploading the attached test-files. Upload of .xml files works.