61469 - collect total reflows that occur during system test

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Build Config, defect, P3)

Description

[Chris Waterson]

Per kmcclusk's suggestion, collect rods's ``reflow statistics'' and report
daily, or even better, display in a slot on tinderbox. Here's info from rods on
what needs to be done to make this work:

First, you need to [build with] MOZ_REFLOW_PERF=1

Then there are two small fixes:

Here are the two diffs (that should be checked in ASAP):

Index: nsPresShell.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsPresShell.cpp,v
retrieving revision 3.360
diff -r3.360 nsPresShell.cpp
6052c6052
<     //mReflowCountMgr->Add(aName, (nsReflowReason)aType);
---
>     mReflowCountMgr->Add(aName, (nsReflowReason)aType);

Index: nsTableOuterFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/table/src/nsTableOuterFrame.cpp,v
retrieving revision 3.173
diff -r3.173 nsTableOuterFrame.cpp
1392c1392
<   DO_GLOBAL_REFLOW_COUNT("nsTableOuterFrame", aReflowState.reason);
---
>   DO_GLOBAL_REFLOW_COUNT("nsTableOuterFrame", aOuterRS.reason);


I'll attach a patch shortly that enables MOZ_REFLOW_PERF via an autoconf option
so it'll work on Linux.

Comment 1

[Chris Waterson]

Attachment: add --enable-reflow-perf configure option

Comment 2

[Kevin McCluskey (gone)]

patch looks good. r=[e-mail]

Comment 3

[Chris Waterson]

rods patch looks good to me to, sr=waterson. cls, can you take a look at my
patch to configure.in?

Comment 4

[chris hofmann]

curt,  another test that we want to add to daily verfication run.
we should figure out some set of urls to hit (start small then go big)
hit those urls with builds enabled to do reflow counting, and then
spit the data out somewhere in daily and longer term trend reports.

It would be good to attach a report, and to provide some idea
of how to get the data to dump on a test run or url page load
so we can start thinking about the best way to show the trend.
does the data just show the number of reflows per session, or 
does it show by pages loaded?
chris h.

Comment 5

[chris hofmann]

assigned this one to curt.

Comment 6

[cls]

r=cls on the configure.in patch.

Comment 7

[Daniel (Leaf) Nunes]

sr=leaf on the configure.in patch

Comment 8

[rods (gone)]

Curt,
I'll check in the changes to nsPresShell.cpp and nsTableOuterFrame - rods

Comment 9

[Chris Waterson]

checked in configure.in changes. this should be ready for a bit of automation
work now...

Comment 10

[Henrik Lynggaard Hansen]

This bug has not been touched since  2000-11-30.

What are the current status of this bug. Is it being kept open for the mentioned
automation work or can it be closed. 

Comment 11

[Tony Mechelynck [:tonymec]]

No reply in 5½ years, no dependencies => INCOMPLETE