614690 - Change click() calls to waitThenClick() in testDownloadStates.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

After waiting for the download state, in consideration for network speeds/latency, the test should wait for the button elements to appear before the test attempts to click on element. This should also be backported on older branches.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

s/click/waitThenClick/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, as what I have remembered now, you reported a similar issue last week. Could you please help me in updating my mind? Did this patch fixes the issue for you?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

IIRC there were two common failure points for me when I was running this test. The first was the timeout waiting for the download window to appear, and the second was the clicks on the download window buttons. The patch looks like it would add robustness to the latter.

This test is very dependent on server responses, so when running on a slow connection the timeouts could be exceeded.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 493123 [details] [diff] [review]
Patch v1 - (default)

Thanks Dave. That explains it. So as long as we do not have a solid API around the download manager lets get this in.

And with the download manager to appear you probably mean the helper application dialog which pops-up and lets you choose to open or save the file. We should get this on file separately.

Comment 5

[Aaron Train [:aaronmt]]

default - http://hg.mozilla.org/qa/mozmill-tests/rev/c7e8a94464c4
1.9.2 - http://hg.mozilla.org/qa/mozmill-tests/rev/75c3e999c0f4
1.9.1 - http://hg.mozilla.org/qa/mozmill-tests/rev/8bb59103e0ec

Comment 6

[u279076]

(In reply to comment #5)
> default - http://hg.mozilla.org/qa/mozmill-tests/rev/c7e8a94464c4
> 1.9.2 - http://hg.mozilla.org/qa/mozmill-tests/rev/75c3e999c0f4
> 1.9.1 - http://hg.mozilla.org/qa/mozmill-tests/rev/8bb59103e0ec

Can this be marked resolved?