Add-on preferences are inaccessible if add-on is disabled, even if add-on provider allows for it

NEW
Unassigned

Status

()

Toolkit
Add-ons Manager
7 years ago
2 years ago

People

(Reporter: Jason Barnabe (np), Unassigned)

Tracking

unspecified
x86
Linux
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

(Reporter)

Description

7 years ago
I'm writing an add-ons provider to get my extension, Stylish, to put its items in the add-ons manager. I'm using the "preferences" UI provided in the add-ons manager to open an edit window.

The add-ons manager seems to make the assumption that only enabled things can have preferences. This makes sense for all the add-ons types that come with Firefox, but not for Stylish. In Stylish, you can edit disabled items, so my provider always sends an optionsURL. The result is that all items coming from Stylish have a Preferences button, but the button only works for enabled items.

I think the add-ons provider should be the one to decide whether enabled items should have preferences available; this should not be hard-coded. http://mxr.mozilla.org/mozilla2.0/source/toolkit/mozapps/extensions/content/extensions.js#463

Alternately, if you don't agree with that statement, then at least disabled items should never the Preferences button.
Yeah I agree. I'd review and approve a simple, well tested patch to fix it, otherwise not going to block the release on this though.
blocking2.0: --- → -
You need to log in before you can comment on or make changes to this bug.