614994 - Update logo for Miramar branding

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[tymerkaev]

Attachment: i1

bug 611697 sets up unofficial branding, but it uses Shredder logos. Logos should be updated.

Comment 1

[Andreas Nilsson (:andreasn)]

Confirmed this was missing from the alpha.

It could have been because it needs a
ac_add_options --with-branding=mail/branding/unofficial
in the mozconfig file at build.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Confirmed this was missing from the alpha.

Yes, intentionally. We decided that we didn't have time to set up logos for Miramar for the alpha and hence just went with the Shredder ones.

We can pick up Miramar ones when we've got some, Andreas could you take this bug and do that?

Comment 3

[Dan Mosedale (:dmose, :dmosedale)]

We talked about this briefly on the driver call and came to the conclusion that we definitely would like the Miramar logo to at least be somehow visually different from Lanikai, even if that's just color differences.  If there's an obvious icon that particularly resonates with a theme more specific to Miramar Beach and that's very little work, that would be nice.  But it's low priority and not worth much time. 

If Bryan and/or Andreas would make an appropriate call here, that would be great.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: work-in-progress proposal

Comment 5

[Mark Banner (:standard8)]

As we've got a WIP on this, I'm going to tentatively say this blocks A2 so that we can have a better logo there.

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: miramar branding for windows and linux

Mac OS X patch coming soon (probably later tonight), need access to my mac first.

Comment 7

[Andreas Nilsson (:andreasn)]

Attachment: with osx graphics as well

Miramar branding for Linux, Windows and OS X

Comment 8

[Andreas Nilsson (:andreasn)]

Does this need code review or is ui-review enough?

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 502888 [details] [diff] [review]
with osx graphics as well

This looks good (all files modified in what seems to be the right manner).

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 502888 [details] [diff] [review]
with osx graphics as well

went through them all.  looks really good, nice work andreas!

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/4e0ccefb6459