Closed
Bug 615072
Opened 14 years ago
Closed 14 years ago
obj decl from top of Parser::letStatement is unused
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
731 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
5500 Parser::letStatement()
declared here:
5502 JSObject *obj;
5506 do {
5537 if (stmt && (stmt->flags & SIF_SCOPE)) {
5538 JS_ASSERT(tc->blockChainBox == stmt->blockBox);
assigned here:
5539 obj = tc->blockChain();
5540 } else {
shadowed here:
5569 JSObject *obj = js_NewBlockObject(tc->parser->context);
5570 if (!obj)
5571 return NULL;
5589 obj->setParent(tc->blockChain());
5611 }
loop only executes once:
5617 } while (0);
|
||
Updated•14 years ago
|
Attachment #496439 -
Flags: review?(jorendorff) → review+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/d0a8bb359a7d
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d0a8bb359a7d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•