Closed Bug 615111 Opened 10 years ago Closed 5 months ago

crash @ nsMsgThreadedDBView::AddKeys - msgHeader is null

Categories

(MailNews Core :: Backend, defect)

x86
All
defect
Not set
critical

Tracking

(thunderbird_esr68 fixed, thunderbird73 fixed)

RESOLVED FIXED
Thunderbird 74.0
Tracking Status
thunderbird_esr68 --- fixed
thunderbird73 --- fixed

People

(Reporter: wsmwk, Assigned: mkmelin)

Details

(Keywords: crash, Whiteboard: [rare])

Crash Data

Attachments

(1 file)

crash [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)]

one crash comment in the last month and reporter - but I does'nt correlate strongly to the crash
bp-5cdf9e7d-1489-4fcf-8715-d9eef2101119 (bendyz) "It's allways crasches when i'm trying to use filter <ctrl+f>"
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0	thunderbird.exe	nsMsgThreadedDBView::AddKeys	mailnews/base/src/nsMsgThreadedDBView.cpp:261
1	thunderbird.exe	nsMsgThreadedDBView::InitThreadedView	mailnews/base/src/nsMsgThreadedDBView.cpp:158
2	thunderbird.exe	nsMsgQuickSearchDBView::Open	mailnews/base/src/nsMsgQuickSearchDBView.cpp:74
3	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
257 m_db->GetMsgHdrForKey(pKeys[i], getter_AddRefs(msgHdr));
258 if (!(m_viewFlags & nsMsgViewFlagsType::kShowIgnored))
259 {
260   PRBool killed;
261   msgHdr->GetIsKilled(&killed); 

msgHeader is null. easily handled.
Crash Signature: [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)]
> msgHeader is null. easily handled.

m_kato, can you handle this?
(most crashes are startup)
Whiteboard: [startupcrash]
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Crash Signature: [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)] → [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)] [@ nsMsgThreadedDBView::AddKeys]
Summary: crash [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)] → crash @ nsMsgThreadedDBView::AddKeys - msgHeader is null
Whiteboard: [startupcrash] → [rare]
We don't seem to have a full stack for any of these
bp-571b1d35-8c01-4335-9bd1-b2cf30180727
bp-155295ce-bf62-4497-b853-175ab0181123

now rare in version 68. Not sure comment 1 is still relevant to present day crashes.

Worth doing anything based on bp-b74cec27-bffe-48cd-bedd-1cd110200122 or keep this open for a rainy day? Or kill it off as not actionable?

Crash Signature: [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)] [@ nsMsgThreadedDBView::AddKeys] → [@ nsMsgThreadedDBView::AddKeys]
Component: Backend → Build Config
Flags: needinfo?(mkmelin+mozilla)

We might as well fix this as it's pretty clear now.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mkmelin+mozilla)
Attachment #9123101 - Flags: review?(benc)
Comment on attachment 9123101 [details] [diff] [review]
bug615111_threaded_view_crash.patch

Review of attachment 9123101 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #9123101 - Flags: review?(benc) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/97590cfd1343
fix crash at nsMsgThreadedDBView::AddKeys. r=benc DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
Attachment #9123101 - Flags: approval-comm-esr68?
Attachment #9123101 - Flags: approval-comm-beta+
Attachment #9123101 - Flags: approval-comm-esr68? → approval-comm-esr68+
Component: Build Config → Backend

Looks like that is another crash, maybe related but not the same as the one originally reported and fixed. I don't see how https://searchfox.org/comm-central/rev/365b1519f0659eb59d785804c7372d525f8334d1/mailnews/base/src/nsMsgThreadedDBView.cpp#118 would crash, but maybe it gets stuck in the loop somehow.

Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.