615111 - crash @ nsMsgThreadedDBView::AddKeys - msgHeader is null

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsMsgThreadedDBView::AddKeys(unsigned int*, int*, char const*, int, int)]

one crash comment in the last month and reporter - but I does'nt correlate strongly to the crash
bp-5cdf9e7d-1489-4fcf-8715-d9eef2101119 (bendyz) "It's allways crasches when i'm trying to use filter <ctrl+f>"
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0	thunderbird.exe	nsMsgThreadedDBView::AddKeys	mailnews/base/src/nsMsgThreadedDBView.cpp:261
1	thunderbird.exe	nsMsgThreadedDBView::InitThreadedView	mailnews/base/src/nsMsgThreadedDBView.cpp:158
2	thunderbird.exe	nsMsgQuickSearchDBView::Open	mailnews/base/src/nsMsgQuickSearchDBView.cpp:74
3	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102

Comment 1

[timeless]

257 m_db->GetMsgHdrForKey(pKeys[i], getter_AddRefs(msgHdr));
258 if (!(m_viewFlags & nsMsgViewFlagsType::kShowIgnored))
259 {
260   PRBool killed;
261   msgHdr->GetIsKilled(&killed); 

msgHeader is null. easily handled.

Comment 2

[Wayne Mery (:wsmwk)]

> msgHeader is null. easily handled.

m_kato, can you handle this?
(most crashes are startup)

Comment 3

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 4

[Wayne Mery (:wsmwk)]

We don't seem to have a full stack for any of these
bp-571b1d35-8c01-4335-9bd1-b2cf30180727
bp-155295ce-bf62-4497-b853-175ab0181123

Comment 5

[Wayne Mery (:wsmwk)]

now rare in version 68. Not sure comment 1 is still relevant to present day crashes.

Worth doing anything based on bp-b74cec27-bffe-48cd-bedd-1cd110200122 or keep this open for a rainy day? Or kill it off as not actionable?

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug615111_threaded_view_crash.patch

We might as well fix this as it's pretty clear now.

Comment 7

[Ben Campbell]

Comment on attachment 9123101 [details] [diff] [review]
bug615111_threaded_view_crash.patch

Review of attachment 9123101 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97590cfd1343
fix crash at nsMsgThreadedDBView::AddKeys. r=benc DONTBUILD

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 73.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/58019f894ca640359219c1fdc11f88da9e3d7011

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 68.5.0:
https://hg.mozilla.org/releases/comm-esr68/rev/3d5f67145587

Comment 11

[Wayne Mery (:wsmwk)]

Assessing crash-stats of the past 3 months I don't see a change in the crash rate, so I'd say the patch had little or no impact.
https://crash-stats.mozilla.org/signature/?signature=nsMsgThreadedDBView%3A%3AAddKeys&date=%3E%3D2019-12-06T07%3A02%3A00.000Z&date=%3C2020-03-06T07%3A02%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#summary

bp-c6725f30-445c-415e-b53b-eb6be0200305 68.5.0. (same stack as bp-26ff19b3-f99c-445d-836d-fc98b0200210 68.4.2)

Comment 12

[Magnus Melin [:mkmelin]]

Looks like that is another crash, maybe related but not the same as the one originally reported and fixed. I don't see how https://searchfox.org/comm-central/rev/365b1519f0659eb59d785804c7372d525f8334d1/mailnews/base/src/nsMsgThreadedDBView.cpp#118 would crash, but maybe it gets stuck in the loop somehow.