615203 - Update eBay.co.uk Search Plugin

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Kev Needham [:kev]]

Per eBay's request, please update the search plugin to be included with Mozilla
products per the attached patch. The changes add suggested search (not yet
active), an updated favicon, and cuts the current number of redirects from the initial search query from 4 to 1. This change should block Fx4 for the en-GB locale.

Comment 1

[Kev Needham [:kev]]

Attachment: Patch for eBay.co.uk Search Plugin

and the patch would probably help, too.

Comment 2

[Kev Needham [:kev]]

Attachment: The real eBay.co.uk patch

Also, it would help if I attached the correct patch. I am going to drink coffee before attempting to file any more bugs this morning. Apologies for the spam.

Comment 3

[Seth Bindernagel]

Comment on attachment 493676 [details] [diff] [review]
The real eBay.co.uk patch

This is good and should land on l10n-central.  Mark, can you land this plugin in your en-GB repository to update the eBay plugin.  When you land that change, can you add a comment to your checking that reads:

"Bug 615203: Updating eBay plugin, r=sethb"

Thanks.

Comment 4

[Mark Tyndall]

Landed on l10n-central.

http://hg.mozilla.org/l10n-central/en-GB/rev/2bbbbda1b760

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Failed testing on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11) Gecko/20100101 Firefox/4.0b11

Actual:
Submitting search takes you to the ebay.co.uk home page.

Expected:
Submitting search takes you to search results for the specified search term.

New favicon is working and relevant search suggestions are appearing.

Comment 6

[Mark Tyndall]

The current (ie landed) search plugin constructs URLs of the form

http://rover.ebay.com/rover/1/710-47297-17704-2/4?mpre=mpre=http://shop.ebay.co.uk/?_nkw=toy+story+3+dvd

There's a [...]?mpre=mpre=[...] which looks wrong; removing one "mpre=" results in a correct redirect to a list of search results.

Comment 7

[Mark Tyndall]

Attachment: Removing extra mpre=

Removes the extra "mpre=".  This now (correctly) redirects to a list of search results.

Comment 8

[Seth Bindernagel]

Comment on attachment 510241 [details] [diff] [review]
Removing extra mpre=

Look good.  Please land and test and then sign off.  Don't forget to sign off.  Also, please add a comment to your checkin that says, "Bug 615203, r=sethb, updating eBay search plugin".

Comment 9

[Mark Tyndall]

Landed:

http://hg.mozilla.org/l10n-central/en-GB/rev/67f14e396191

I'll sign off & resolve this after testing...

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.

Comment 11

[Johnathan Nightingale [:johnath]]

Are we clear to resolve here?

Comment 12

[Mark Tyndall]

Resolving - this works. (Timing of events conspired against me...)

I'm assuming comment 10 isn't a blocking issue, but I also assume that the flags and status prevent this bug staying open to keep track of that. (I'm also AFK pretty much from now till the weekend, so I'll leave that decision to someone else.  Seth?)

Comment 13

[Axel Hecht [:Pike]]

Yes, the type stuff is not blocking. Gonna look at the sign-off next, thanks.

Comment 14

[Kev Needham [:kev]]

Thanks folks. Clearing this out is much appreciated!

Comment 15

[Kev Needham [:kev]]

Axel, this looks good to me, fwiw. I'm going to resolve the metabug, as I think we're good.