Closed Bug 615256 Opened 9 years ago Closed 9 years ago

warning: 'PRBool FramesOnSameLineHaveZeroHeight(nsIFrame*)' defined but not used

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

remove it
889 bytes, patch
mats
: review+
dbaron
: approval2.0+
Details | Diff | Splinter Review 
layout/base/nsCaret.cpp:150:
 warning: ‘PRBool FramesOnSameLineHaveZeroHeight(nsIFrame*)’ defined but not used
Attached patch remove it — — Splinter Review 
this merely removes dead code and thus is safe for 2.0

http://mxr.mozilla.org/mozilla-central/search?string=FramesOnSameLineHaveZeroHeight

Found one matching line

/layout/base/nsCaret.cpp (View Hg log or Hg annotations)

    * line 150 -- FramesOnSameLineHaveZeroHeight(nsIFrame* aFrame)

Found one matching line
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #493717 - Flags: review?(matspal)
Attachment #493717 - Flags: approval2.0?
Comment on attachment 493717 [details] [diff] [review]
remove it

r=mats
Attachment #493717 - Flags: review?(matspal) → review+
Attachment #493717 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/5d92ead2065b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.