Closed
Bug 615382
Opened 14 years ago
Closed 14 years ago
ByteArray::Uncompress swaps len/cap on the error path
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file)
|
818 bytes,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
See patch, when we have an error we "restore" the fields incorrectly.
Attachment #493819 -
Flags: review?(rreitmai)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 493819 [details] [diff] [review]
Patch
Another option would have been to swap the order to match the original locals; i.e. data, cap, len, pos, but either way is fine.
Also we're sure m_array won't be gc'd during this process, correct?
Attachment #493819 -
Flags: review?(rreitmai) → review+
|
Reporter | |
Comment 2•14 years ago
|
||
TR 5590:fc1b618ce3b2
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•