Couple of tweaks for the performance warnings: 1) In the code you look for settings.PERFORMANCE_WARNINGS but settings.py has PERFORMANCE_NOTES. We probably don't need either at this point. 2) "15:50 <potch> I just looked and I'm not actually geting the data from the db right now" -- there is some test data in the db now on PAMO. Rows with no add-on id are the baseline numbers. I hardcoded them at 200ms for purposes of our testing. 3) Fligtar says that if any spread is more than 20% we should show it on the page. The numbers here are different per OS, but regardless of user-agent's OS, we should show the warning if any OS on our end if more than 20%.
Where will this number come from? Will the value be hung on the addon object? It would be awesome if there was just a single number I could look at- the % that will be displayed.
Values are in the perf_results table right now. Jbalogh, can you get potch what he needs here?
potch: you want the 860% slower number? So Addon.slowness => 860?
(In reply to comment #3) > potch: you want the 860% slower number? So Addon.slowness => 860? yup.
http://github.com/jbalogh/zamboni/commit/3e454d4 Get the goods at Addon.ts_slowness. Run `django cron update_perf` to get some data. If you have perf_results data.
Also, these warnings should only show up on /firefox, and please change "your browser" to "Firefox" in both places of the warning. "Learn more" doesn't need to be forced onto a separate line and please lowercase "More"
btw, is there somewhere I can look at this data before we start showing these all over the place?
PAMO has a few results, see perf_results for the ids. For the Q4 goal I suspect we'll need alice to manually inject the results to the db for the add-ons she's been generating reports for in the past. We've hit some slowness on the hardware/security front for the fully automated setup.
I checked out the results on preview and they're pretty incomplete. I'd like to review the actual results before we push this feature live. If there are tons of impacted add-ons, we may want to raise our threshold initially and email the developers to give them a month or so to get their results down before we lower the threshold again.
The numbers are not accurate yet (extremes aren't thrown out, for one thing). That said, potch, can you give us a flag in settings.py to show these or not? Thanks.
Re-opening for comment #6