Closed Bug 615437 Opened 14 years ago Closed 13 years ago

warning: comparison between signed and unsigned integer expressions in nsXULCommandDispatcher::UpdateCommands

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

patch
776 bytes, patch
neil
: review+
dbaron
: approval2.0-
Details | Diff | Splinter Review 
content/xul/document/src/nsXULCommandDispatcher.cpp:
 In member function ‘virtual nsresult nsXULCommandDispatcher::UpdateCommands(const nsAString_internal&)’:
426: warning: comparison between signed and unsigned integer expressions
Attached patch patch — — Splinter Review 
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #493881 -
        Flags: review?(neil)

        Attachment #493881 -
        Flags: approval2.0?

    
    

    
  
Comment on attachment 493881 [details] [diff] [review]
patch

[I wonder why the variable was named u, I guess i makes more sense now ;-)]

        Attachment #493881 -
        Flags: review?(neil) → review+

    
    

    
  
rotfl

my guess is u is short for updater

    
    

    
  
Comment on attachment 493881 [details] [diff] [review]
patch

This should land after we branch for Gecko 2.0 / Firefox 4.

        Attachment #493881 -
        Flags: approval2.0? → approval2.0-

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/dd6d201316bb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: