61544 - Implement ZIP_TestArchive

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

Description

[Samir Gehani]

The stub installers need a way to check the integrity of downloaded zippies.
The PKZIP format includes a CRC32 checksum for each item in the archive. We can
leverage this information by verifying the checksum of all items in an archive,
indicating a failed checksum when encountered. (The stubs can the proceed to
redownload the corrupt archives.)

The API required would need to be exposed in the standalone libjar as:

	/**
	 * ZIP_TestArchive
	 *
	 * Tests the integrity of this open zip archive by extracting each
	 * item to memory and performing a CRC check.
	 *
	 * @param   hZip      handle obtained from ZIP_OpenArchive
	 * @return  status code (success indicated by ZIP_OK)
	 */
	PRInt32 ZIP_TestArchive( void *hZip );

Comment 1

[Samir Gehani]

Attachment: Patch of ZIP_TestArchive() implementation and XPInstall client use of the new API.

Comment 2

[Samir Gehani]

Dan,
Please review the attached patch.

Comment 3

[Samir Gehani]

Attachment: Revised patch per dveditz's review pass #1 comments

Comment 4

[Daniel Veditz [:dveditz]]

r=dveditz

Comment 5

[Alec Flett]

looks ok to me... I can only assume the actual CRC testing is doing the right
thing :)
sr=alecf

Comment 6

[Daniel Veditz [:dveditz]]

Hasn't this been checked-in?

Comment 7

[Sean Su]

I can confirm that this has been checked in.  I'll mark it fixed on behalf of Samir.

Comment 8

[Samir Gehani]

Oops, was off for vacation and forgot to makr it fixed.  Thanks Sean!

Comment 9

[Jimmy Lee]

Build: 2001-03-06-11-Mtrunk(WIN), 2001-03-06-10-trunk(MAC), 
2001-03-06-08-Mtrunk(LINUX)

This is working as expected.  Corrupted archives will report -207 (Unable to 
read archive) from the install.log.  Marking Verified!