615549 - Frequent exceptions occur when calling getBrowserState after quit-application-granted notification

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Michael Kraft [:morac]]

Attachment: Session Manager log file

My session manager add-on makes a call to SessionStore's getBrowserState API call upon the quit-application-granted notification.  It will also make a call later on in the shutdown process, but it will use the session data returned at quit-application-granted if session data isn't available later or isn't valid.

Recently I've been noticing that occasionally the getBrowserState call is throwing an exception when called after the quit-application-granted notification under Firefox 3.6.12.  It doesn't seem to do it if I simply start Firefox and then close the browser window, but I've noticed periodically after normal browser usage.  I've seen indications of it going back to Firefox 3.6.8, but I don't know when it actually started.  It's been happening more frequently lately.

The next time I launch Firefox, the browser indicates there was a crash though all windows and tabs are saved in the crash data, so data is being saved, but something isn't shutting down properly.


The exception I get is:

[JavaScript Error: "total[0] is undefined" {file: "file:///C:/Program%20Files/Mozilla%20Firefox/components/nsSessionStore.js" line: 1769}]' when calling method: [nsISessionStore::getBrowserState]

This would seem to indicate that all window data is gone at that point, which seems very odd since that shouldn't be happening as far as I can tell since I don't have the browser set to clear private data at shutdown.  Even if I did the data should be available at quit-application-granted since that fires prior to browser:purge-session-history.

I normally shut down Firefox by closing the last browser window (I do not use File->Exit).  Firefox's startup option is set to "Show my windows and tabs from last time".


This probably won't mean anything to anyone but me, but I'm attaching the log file Session Manager makes when shutting down the browser since it shows the shutdown notification events.