Bad argument failure in testCloseWindow.js

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: aaronmt, Assigned: aaronmt)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
MODULE: testCloseWindow.js
TEST: testCloseWindow
ERROR: Name constructor did not recieve enough arguments. 
BRANCH: 1.9.2/1.9.1
PLATFORM: all

http://hg.mozilla.org/qa/mozmill-tests/file/21401ef2bbd7/firefox/testPrivateBrowsing/testCloseWindow.js#l122
(Assignee)

Comment 1

8 years ago
Created attachment 494005 [details] [diff] [review]
Patch v1 - (1.9.2)

Argument should be name not id. This was revealed with the modal dialog and window handling update.
Attachment #494005 - Flags: review?(anthony.s.hughes)
Comment on attachment 494005 [details] [diff] [review]
Patch v1 - (1.9.2)

># HG changeset patch
># User Aaron Train <atrain@mozilla.com>
># Date 1291134712 18000
># Branch mozilla1.9.2
># Node ID f7afffc4cb59c54422418a6b9fe2e137b0fab505
># Parent  21401ef2bbd72fcdb6ee26036b5b1a55a56d0d69
>Bug 615565 - Bad argument failure in testCloseWindow.js. r=ashughes
>
>diff --git a/firefox/testPrivateBrowsing/testCloseWindow.js b/firefox/testPrivateBrowsing/testCloseWindow.js
>--- a/firefox/testPrivateBrowsing/testCloseWindow.js
>+++ b/firefox/testPrivateBrowsing/testCloseWindow.js
>@@ -119,7 +119,7 @@
>     var tab = controller.tabs.getTab(i);
>     controller.waitForPageLoad(tab);
> 
>-    var elem = new elementslib.Name(tab, LOCAL_TEST_PAGES[i].id);
>+    var elem = new elementslib.Name(tab, LOCAL_TEST_PAGES[i].name);
>     controller.assertNode(elem);
>   }
> }

nit: can you use a more descriptive variable name?
Attachment #494005 - Flags: review?(anthony.s.hughes) → review-
(Assignee)

Comment 3

8 years ago
Created attachment 494474 [details] [diff] [review]
Patch v1.1 - (1.9.2)

Renamed to reflect the element they reference
Attachment #494005 - Attachment is obsolete: true
Attachment #494474 - Flags: review?(anthony.s.hughes)
Comment on attachment 494474 [details] [diff] [review]
Patch v1.1 - (1.9.2)

Looks ok -- over to Henrik for landing approval.
Attachment #494474 - Flags: review?(hskupin)
Attachment #494474 - Flags: review?(anthony.s.hughes)
Attachment #494474 - Flags: review+
Attachment #494474 - Flags: review?(hskupin) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/qa/mozmill-tests/rev/ed46d7e6b4c7 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/0f616f62805c (1.9.1)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.