615565 - Bad argument failure in testCloseWindow.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

MODULE: testCloseWindow.js
TEST: testCloseWindow
ERROR: Name constructor did not recieve enough arguments. 
BRANCH: 1.9.2/1.9.1
PLATFORM: all

http://hg.mozilla.org/qa/mozmill-tests/file/21401ef2bbd7/firefox/testPrivateBrowsing/testCloseWindow.js#l122

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.2)

Argument should be name not id. This was revealed with the modal dialog and window handling update.

Comment 2

[u279076]

Comment on attachment 494005 [details] [diff] [review]
Patch v1 - (1.9.2)

># HG changeset patch
># User Aaron Train <[e-mail]>
># Date 1291134712 18000
># Branch mozilla1.9.2
># Node ID f7afffc4cb59c54422418a6b9fe2e137b0fab505
># Parent  21401ef2bbd72fcdb6ee26036b5b1a55a56d0d69
>Bug 615565 - Bad argument failure in testCloseWindow.js. r=ashughes
>
>diff --git a/firefox/testPrivateBrowsing/testCloseWindow.js b/firefox/testPrivateBrowsing/testCloseWindow.js
>--- a/firefox/testPrivateBrowsing/testCloseWindow.js
>+++ b/firefox/testPrivateBrowsing/testCloseWindow.js
>@@ -119,7 +119,7 @@
>     var tab = controller.tabs.getTab(i);
>     controller.waitForPageLoad(tab);
> 
>-    var elem = new elementslib.Name(tab, LOCAL_TEST_PAGES[i].id);
>+    var elem = new elementslib.Name(tab, LOCAL_TEST_PAGES[i].name);
>     controller.assertNode(elem);
>   }
> }

nit: can you use a more descriptive variable name?

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (1.9.2)

Renamed to reflect the element they reference

Comment 4

[u279076]

Comment on attachment 494474 [details] [diff] [review]
Patch v1.1 - (1.9.2)

Looks ok -- over to Henrik for landing approval.

Comment 5

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/qa/mozmill-tests/rev/ed46d7e6b4c7 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/0f616f62805c (1.9.1)