615621 - embedding does not compile (missing jsstrinlines.h file)

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Franck]

I fail to compile my embedding against the latest tracemonkey tip because the compiler cannot find jsstrinlines.h:
  js\win32_dbg\dist\include\jsscope.h(58) : fatal error C1083: Cannot open include file: 'jsstrinlines.h': No such file or directory

I build tracemonkey like this:
  cd js/Win32_dbg
  ../src/configure (...)

In previous tips, jsstrinlines.h was located here:
  js\Win32_dbg\dist\include\jsstrinlines.h

In the latest tip, js\Win32_dbg\dist\include does not contains jsstrinlines.h

Comment 1

[Andreas Gal :gal]

Makefile bug. Try adding jsstrinlines.h to the INCLUDES list in Makefile.in

Comment 2

[Franck]

Thanks, I added it in INSTALLED_HEADERS (like jsobjinlines.h, ...) and every works.

Comment 3

[Franck]

just note that now more files are missing in the INSTALLED_HEADERS section:
jsstrinlines.h
jscntxtinlines.h
jskeyword.tbl

Comment 4

[Jeff Walden [:Waldo]]

I don't think we intend to publicly provide these headers.  See bug 662946 as well as this thread:

http://groups.google.com/group/mozilla.dev.tech.js-engine.internals/browse_thread/thread/b0d57f09cafd843d#

We'd really like to get down to just jsapi.h, jsdbgapi.h, and whatever few headers they depend upon, more or less -- or move stuff that we want exposed into those files.  (I'm thinking JS_ASSERT and JS_STATIC_ASSERT in jsutils.h, which I think we might treat as semi-public, but my memory's hazy.)  *inlines.h files certainly are not going to be exposed.  You're free to change source drops however you want, of course, but we're not going to make this change ourselves.

Comment 5

[Franck]

Does wontfixing this bug mean that I will not be able to build tracemonkey in a separate directory ?
Like:
  cd js/Win32_dbg
  ../src/configure

Comment 6

[Jeff Walden [:Waldo]]

I'm pretty sure you can configure in any random directory, then build in it, completely separate from the actual JS tree.  The presence or absence of files in INSTALLED_HEADERS shouldn't change that.