61568 - javascript strict warnings in menulistBindings.xml

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://global/content/menulistBindings.xml#menulist.selectedIndex (setter) 
line 13: function onset does not always return a value

Comment 1

[Peter "jag" Annema]

Attachment: [patch] fix warnings and evil no-value returns

Comment 2

[Blake Ross]

r=blake

Comment 3

[Henrik Gemal]

so what's the next thing to do, to get this checked in?

Comment 4

[Peter "jag" Annema]

Easy, now I e-mail hyatt :-)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 6

[Peter "jag" Annema]

Or ask Ben ;-)

Btw, in the mean time someone sneaked in a different version, which did
s/return/return -1/ meaning you couldn't do something like:
var foo = menuList.selectedIndex = 5; // foo could be -1

Checked in this (better) fix.

Comment 7

[sairuh (rarely reading bugmail)]

rubberstamp vrfy --unless you have a testcase i could use to further verify. :)