Closed
Bug 615764
Opened 14 years ago
Closed 14 years ago
Remove nsRadioUpdateValueMissingVisitor
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
4.47 KB,
patch
|
sicking
:
review+
sicking
:
approval2.0+
|
Details | Diff | Splinter Review |
Follow-up from bug 610687: we don't need nsRadioUpdateValueMissingVisitor anymore. UpdateValueMissingValidityState() should be used instead.
Attachment #494236 -
Flags: review?(bzbarsky)
|
Assignee | |
Comment 1•14 years ago
|
||
Note that this should better for performance given that UpdateValueMissingValidityState() tries to be clever than the visitor and with bug 615764 fixed, the visitor will call UpdateValueMissingValidityState() on all radio group elements...
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [passed-try][needs-review]
|
|
Assignee | |
Updated•14 years ago
|
Attachment #494236 -
Flags: review?(bzbarsky) → review?(jonas)
Attachment #494236 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #494236 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [passed-try][needs-review] → [passed-try][needs-approval]
|
|
Assignee | |
Comment 2•14 years ago
|
||
Approval request: it's just a follow-up from bug 610687 which should be harmless and make us save some cycles and bits.
Attachment #494236 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [passed-try][needs-approval] → [passed-try][needs-landing]
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/5a00160adc4e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [passed-try][needs-landing]
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•