615787 - Document._clean_category() without an ID updates all docs without parents :(

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Rebecca Billings [:rbillings]]

Articles are created with 'troubleshooting', as we migrated articles. For unknown reasons the categories are flipping. At last count all articles had been flipped to the 'Navigation' category.

Comment 2

[James Socol [:jsocol, :james]]

Now everything has moved to Troubleshooting.

Comment 3

[James Socol [:jsocol, :james]]

On support-stage, everything is in Troubleshooting. Trying to find a way to switch it all somewhere else.

Comment 4

[James Socol [:jsocol, :james]]

master: https://github.com/jsocol/kitsune/commit/0403ec
2.3.x: https://github.com/jsocol/kitsune/commit/d960727

Comment 5

[James Socol [:jsocol, :james]]

For posterity:

In Document._clean_category() we call something like

  self.translations.all().update(category=self.category)

Unfortunately, when you call that on an unsaved article, the SQL it generates to get translations.all() is something like: "SELECT id, ... WHERE parent_id IS NULL". So it was changing all documents without a parent, which is 1) all of English, and 2) any docs in other languages that aren't translations.

This sucks. It's dataloss, but maybe we can get close to correct with a big-ol-SQL file doing some updates. We still have Paul's migration data, we should be able to do something like pull out ID and Category and run it as an update. Filing a new bug for that.

Any articles created last night after the migration will have to be manually moved back.

Comment 6

[Paul Craciunoiu [:paulc]]

... I feel so... betrayed... Django should warn about this ... at least in their documentation. Maybe they do and we all missed it.

Comment 7

[Rebecca Billings [:rbillings]]

Verified creating a new document with a non-default category did not switch existing US documents without a parent.