615801 - 'Many Planets Deep' demo triggers endless JS exceptions

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Josh Matthews [:jdm]]

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/webkit/ManyPlanetsDeep.html

Error: uncaught exception: [Exception... "Could not convert JavaScript argument - 0 was passed, expected object. Did you mean null? arg 1 [nsIDOMWebGLRenderingContext.bindTexture]"  nsresult: "0x80570035 (NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL)"  location: "JS frame :: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/webkit/ManyPlanetsDeep.html :: drawPicture :: line 191"  data: no]

Comment 1

[Josh Matthews [:jdm]]

Also, if you open the error console, the framerate slows down considerably.

Comment 2

[juan becerra [:juanb]]

This feels like it should block. The difference in frame rate is very noticeable. Nominating.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

This is not our bug, it's a bug in this JS demo. The error message that you get points to line 191 in https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/webkit/ManyPlanetsDeep.html and there we have

            ctx.bindTexture(ctx.TEXTURE_2D, 0);

the parameter 0 here is really a bug, only an object may be passed here, so this code really is wrong, the fix is to use null instead, and our behavior and error message here are perfect!

Comment 4

[juan becerra [:juanb]]

That works for me :)