615825 - Not putting enough space around {for} tags can collapse blocks incorrectly

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Kadir Topal [:atopal]]

Some localized articles have {for fx3} in them. Currently we display a blank page when that happens, even if there are parts marked as {for fx35}, see here: https://support.mozilla.com/it/kb/Individuare%20la%20versione%20di%20Firefox%20utilizzata#os=mac&browser=fx35

The parser should just ignore the parts marked as {for fx3}, so we don't have to immediately work on hundreds of localized articles

Comment 1

[David Tenser [:djst]]

(In reply to comment #0)
> The parser should just ignore the parts marked as {for fx3}, so we don't have
> to immediately work on hundreds of localized articles

Wait, why? This looks like a bug where the fx35 block is ignored for some reason, but that doesn't mean we should ignore fx3 for those (rare) users who are on that platform.

Unless I misunderstand something here, the correct solution is to actually show the fx35 content, which this article actually does include.

Comment 2

[Kadir Topal [:atopal]]

Yeah, apparently the parser chokes on {for fx3}, so whatever we decide on for {for fx3}, it should not affect what we display for other versions.

Comment 3

[Kadir Topal [:atopal]]

Okay, apparently we already decided what to do for fx2 and fx3: They should be displayed to users visiting SUMO with those browsers, but the versions should not show up on the version picker.

Comment 4

[James Socol [:jsocol, :james]]

Looking at the source of the article, and in preview, this can be fixed by replacing

{for fx3}
{for win}Stuff...{/for}
{/for}
{for fx35}
{for win}Stuff...{/for}
{/for}

with

{for fx3}

{for win}stuff...{/for}

{/for}

...etc

Which is part of the "using the same tag for both inline and block-level" issue. The solution that jumps out at me is to make the For parser not require blank lines on either side of a block-level {for} tag but I'm not immediately sure what the consequences of that will be for inline {for} tags, and don't want to immediately create another or worse bug in the process.

Comment 5

[Paul Craciunoiu [:paulc]]

This seems related to the discussion from bug 614465 comment 2.

Comment 6

[Erik Rose [:erik][:erikrose]]

Fixed on master (https://github.com/jsocol/kitsune/commit/23934a28cc4813d44c2866293a51ba1ca3ea2646) and for 2.3.2 (https://github.com/jsocol/kitsune/commit/4b288eecc2f2c06ef9d5e6ce46d973df863955cc).

Comment 7

[Rebecca Billings [:rbillings]]

Verified article in comment 4 displays all data, no fx2 or fx3 option in description