Closed Bug 615831 Opened 11 years ago Closed 11 years ago

comparison between signed and unsigned integer expressions in nsBaseAppShell::RunSyncSections

Categories

(Core :: Widget, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

widget/src/xpwidgets/nsBaseAppShell.cpp:
 In member function ‘void nsBaseAppShell::RunSyncSections()’:
353: warning: comparison between signed and unsigned integer expressions
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #494344 - Flags: review?(neil)
Attachment #494344 - Flags: approval2.0?
Comment on attachment 494344 [details] [diff] [review]
patch

>+  for (PRInt32 i=0; i<mSyncSections.Count(); i++) {
Nit: would be nice to use standard spacing style here too i = 0; i < etc.
Attachment #494344 - Flags: review?(neil) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #494344 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Landed (w/ spacing fix per comment 2):
http://hg.mozilla.org/mozilla-central/rev/959e7a50a125
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.