615851 - Possible integer overflow in liboggplay

Status: VERIFIED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Josh Bressers]

I'm quite certain this is a non issue, it's just something that should get fixed as it could pose a problem in the future.

When building the liboggplay code, newer versions of gcc emit a number of these warnings:

oggplay_private.h: In function 'oggplay_check_add_overflow':
oggplay_private.h:325:9: warning: comparison of unsigned expression >= 0 is always true
In file included from oggplay_callback_info.c:38:0:
oggplay_private.h:326:9: warning: comparison of unsigned expression >= 0 is always true

The code in question is this:

  if (sizeof(size_t) < sizeof(long)) {
    /* check whether the number fits into a size_t */
    if
    (
      (b < 0) ?
        ((OGGPLAY_TYPE_MAX(size_t)+b >= 0) ? 0 : 1) :
        ((OGGPLAY_TYPE_MAX(size_t)-b >= 0) ? 0 : 1)
    )

I don't know of any architectures where sizeof(size_t) < sizeof(long), so this code should never get hit.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #0)
> I don't know of any architectures where sizeof(size_t) < sizeof(long), so this
> code should never get hit.

I agree. We also don't use liboggplay on trunk any more, so this shouldn't be a problem.