Note: There are a few cases of duplicates in user autocompletion which are being worked on.

crash sending message [@ nsMsgBuildMessageByName]

RESOLVED FIXED in Thunderbird 20.0

Status

MailNews Core
Composition
--
critical
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: wsmwk, Assigned: rkent)

Tracking

({crash})

Trunk
Thunderbird 20.0
x86
Windows Vista
crash

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

crash sending message [@ nsMsgBuildMessageByName]

bp-c6fe8964-eb51-4826-bd04-74dbc2101124 (nca1061) "everytime I reply to an e-mail Thunderbird crashes"
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0	thunderbird.exe	nsMsgBuildMessageByName	mailnews/compose/src/nsMsgPrompts.cpp:75
1	thunderbird.exe	nsMsgBuildMessageWithTmpFile	mailnews/compose/src/nsMsgPrompts.cpp:90
2	thunderbird.exe	nsMsgComposeAndSend::GatherMimeAttachments	mailnews/compose/src/nsMsgSend.cpp:637
3	thunderbird.exe	nsMsgComposeAndSend::HackAttachments	mailnews/compose/src/nsMsgSend.cpp:2752
4	thunderbird.exe	nsMsgComposeAndSend::Init	mailnews/compose/src/nsMsgSend.cpp:3451
5	thunderbird.exe	nsMsgComposeAndSend::CreateAndSendMessage	mailnews/compose/src/nsMsgSend.cpp:4293
6	thunderbird.exe	nsMsgCompose::_SendMsg	mailnews/compose/src/nsMsgCompose.cpp:1054
7	thunderbird.exe	nsMsgCompose::SendMsg	mailnews/compose/src/nsMsgCompose.cpp:1251
Wayne might be worth asking that user if -safe-mode helps !
done.
fwiw, user has lightning and adblock extensions only
Crash Signature: [@ nsMsgBuildMessageByName]
It seems to be that this is typo of parameter of nsMsgBuildMessageWithTmpFile.  We should use mHTMLFile instead of mTempFile.
Assignee: nobody → m_kato
Created attachment 551372 [details] [diff] [review]
fix

Updated

6 years ago
Attachment #551372 - Flags: review?(dbienvenu)

Comment 5

6 years ago
thx for the patch - isn't this code wrong as well?

  nsCOMPtr<nsIInputStream> inputFile;
  rv = NS_NewLocalFileInputStream(getter_AddRefs(inputFile), input_file);
  if (NS_FAILED(rv))
  {
    if (mSendReport)
    {
      nsAutoString error_msg;
      nsMsgBuildMessageWithFile(mTempFile, error_msg);
      mSendReport->SetMessage(nsIMsgSendReport::process_Current, error_msg.get(), PR_FALSE);

and for good measure, I'm thinking it would be good to add a null check in nsMsgBuildMessageByName so we don't crash with a null aFile.

Comment 6

6 years ago
Comment on attachment 551372 [details] [diff] [review]
fix

minusing because I'd like to have a patch that fixes the other issues I mentioned. Using an NS_ENSURE_ARG_POINTER(aFile) in nsMsgBuildMessageByName along with using the correct file in that other instance of nsBuildMessageWithTmpFile would be an automatic r+.
Attachment #551372 - Flags: review?(dbienvenu) → review-
(Assignee)

Comment 7

5 years ago
Created attachment 688506 [details] [diff] [review]
with review comments

Since I'm generating one of these crashes in my ExQuilla extension, I figure I should go ahead and do the core checks.
Assignee: m_kato → kent
Attachment #551372 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #688506 - Flags: review?(irving)
Comment on attachment 688506 [details] [diff] [review]
with review comments

Review of attachment 688506 [details] [diff] [review]:
-----------------------------------------------------------------

These crashes happen in the middle of producing a "can't open file" message to present to the user - it would be interesting to know what causes the file open to fail.
Attachment #688506 - Flags: review?(irving) → review+
(Assignee)

Comment 9

5 years ago
Comment on attachment 688506 [details] [diff] [review]
with review comments

Checked in https://hg.mozilla.org/comm-central/rev/ff830fd6b02a
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.