Closed
Bug 615881
Opened 14 years ago
Closed 14 years ago
fix bugs in handling of NPPluginFuncs structure's size and version fields
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(blocking2.0 final+)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
|
8.96 KB,
patch
|
benjamin
:
review+
jaas
:
approval2.0+
|
Details | Diff | Splinter Review |
WRT the NPPluginFuncs structure: 1) Gecko is not initializing the version field of the structure before passing it to the plugin. 2) In-tree plugins are setting the structure version. That is the browser's job, plugins shouldn't do it. 3) In-tree plugins are overwriting the size of the structure passed to them. Plugins shouldn't be doing this - the size field tells them the size, they can't know it otherwise and shouldn't set it. 4) In-tree plugins are not properly checking the size of the structure before writing to it.
Attachment #494416 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #494416 -
Flags: review?(benjamin) → review+
Attachment #494416 -
Flags: approval2.0+
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/9280c6d82204
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•