Closed Bug 615881 Opened 9 years ago Closed 9 years ago

fix bugs in handling of NPPluginFuncs structure's size and version fields

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

WRT the NPPluginFuncs structure:

1) Gecko is not initializing the version field of the structure before passing it to the plugin.

2) In-tree plugins are setting the structure version. That is the browser's job, plugins shouldn't do it.

3) In-tree plugins are overwriting the size of the structure passed to them. Plugins shouldn't be doing this - the size field tells them the size, they can't know it otherwise and shouldn't set it.

4) In-tree plugins are not properly checking the size of the structure before writing to it.
blocking2.0: --- → final+
Attached patch fix v1.0Splinter Review
Attachment #494416 - Flags: review?(benjamin)
Attachment #494416 - Flags: review?(benjamin) → review+
Attachment #494416 - Flags: approval2.0+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/9280c6d82204
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.