comparison between signed and unsigned integer expressions in UnhookTextRunFromFrames

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
layout/generic/nsTextFrameThebes.cpp:
 In function ‘void UnhookTextRunFromFrames(gfxTextRun*, nsTextFrame*)’:
455: warning: comparison between signed and unsigned integer expressions

problems seem to stem from:
struct TextRunUserData {
  TextRunMappedFlow* mMappedFlows;
  PRInt32            mMappedFlowCount;

  PRUint32           mLastFlowIndex;
};
Assignee

Comment 1

9 years ago
Posted patch proposal (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #494424 - Flags: review?(matspal)
Attachment #494424 - Flags: approval2.0?

Updated

9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 494424 [details] [diff] [review]
proposal

There's now a redundant cast in "PRUint32(userData->mMappedFlowCount)".

r=mats
Attachment #494424 - Flags: review?(matspal) → review+
Assignee

Comment 3

9 years ago
Attachment #494424 - Attachment is obsolete: true
Attachment #494974 - Flags: review+
Attachment #494974 - Flags: approval2.0?
Attachment #494424 - Flags: approval2.0?
Comment on attachment 494974 [details] [diff] [review]
fix inside DEBUG_roc too :)

This should land after we branch for Gecko 2.0 / Firefox 4.
Attachment #494974 - Flags: approval2.0? → approval2.0-

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/e54e13ff337a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.