Closed Bug 615964 Opened 14 years ago Closed 14 years ago

avmplus list classes adding subtracting 8 from pointers

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P1)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Platform:
x86_64
Windows 7
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 11 - Serrano

People

(Reporter: treilly, Assigned: treilly)

References

Details

Attachments

(1 file)

different cast approach fixes problem
8.94 KB, patch
stejohns
: review+
edwsmith
: superreview+
stejohns
: feedback+
Details | Diff | Splinter Review 
Specifically this is happening on x64 DebugDebugger builds with respect to E4XNode.   If you put a break on the get/add calls in E4XNode on m_attributes->list you can see this happening before the call to to_gc in add and on the way out, appears to be related to casting or something.
using reinterpret_cast<MMgc::GCObject*> instead of to_gc fixes the problem, will try that in the sandbox...

        Attachment #494500 -
        Flags: review?

    
  

        Attachment #494500 -
        Flags: review? → feedback?(stejohns)

    
  
Assignee: nobody → treilly
Status: NEW → ASSIGNED

    
  

        Attachment #494500 -
        Flags: feedback?(stejohns) → feedback+

    
    

    
  
Comment on attachment 494500 [details] [diff] [review]
different cast approach fixes problem

Sandbox results look good, engaging full review.

        Attachment #494500 -
        Flags: superreview?(edwsmith)

        Attachment #494500 -
        Flags: review?(stejohns)

    
  

        Attachment #494500 -
        Flags: review?(stejohns) → review+

    
  

        Attachment #494500 -
        Flags: superreview?(edwsmith) → superreview+

    
    

    
  
changeset: 5633:30099a30a64f
user:      Tommy Reilly <treilly@adobe.com>
summary:   Bug 615964: avmplus list classes adding/subtracting 8 from pointers (r=stejohns,sr=edwsmith)

http://hg.mozilla.org/tamarin-redux/rev/30099a30a64f

    
  
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
This approach generates some warnings in the player build configs, reopening

    
    

    
  
This fixed the problem by not using the list classes from a header:

http://hg.mozilla.org/tamarin-redux/rev/cfdd1779b8b1

And this made our project as strict as the player:

http://hg.mozilla.org/tamarin-redux/rev/8b0f0206ca36
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED

    
  
Flags: flashplayer-bug+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: