61597 - image given wrong size when only width attribute specified

Status: RESOLVED WORKSFORME

(Core :: Layout: Tables, defect, P3)

Description

[P Wagland]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.18pre15 i686; en-US; m18) Gecko/20001127
BuildID:    2000112708

Go to the URL (http://www.wagland.net/mozilla/bug1/index.html) and you can see
the problem easily. The vertical bar (one pixel wide) is not correctly sized
when only the width attribute is given. This looks like it is being doubled in size.

Reproducible: Always
Steps to Reproduce:
1. Go to the web site
2. look at page

Actual Results:  three of the tables display correctly. one does not. The one
that specifies only the width is not displayed correctly.

Expected Results:  All tables would look the same.

Comment 1

[P Wagland]

Just in case it helps any, this bug can also be seen when

user_pref("nglayout.debug.enable_scary_view_manager", true);

is in the users prefs.js file. I.e. this makes no difference to this bug.

Comment 2

[Boris Zbarsky [:bzbarsky]]

linux build 2000-11-27-08 -- all the images look identical to me..

Comment 3

[P Wagland]

*sigh* That is why I love computers...so predictable :-)
Anyway, I have updated the URL to include this link:
http://www.wagland.net/mozilla/bug1/bug-shot.png

It shows the bug happening on my browser. How can I tell what is causing this.
Could it be a .so problem? I am using (mostly) SuSE 7.0.

Comment 4

[Kathleen :Brade]

this bug should probably go to Pam or Karnaze

Comment 5

[P Wagland]

Just thought I would confim that I can see this bug with the Linux XPI install
of build 2000120421. Any ideas on where I might look in the code to start
tracing this bug? I do not have the code yet, but would love to get this
fixed...I use postbank.nl a fair bit.. :-)

Comment 6

[Fabian Guisset]

worksforme build 2000121120 win32, all the images look exactly the same

Comment 7

[Chris Petersen]

I can't reproduce this problem eiher with the Dec 12th build. Reporter, can you
pull a newer build and try again.

Comment 8

[Chris Petersen]

Changing component to HTML tables

Comment 9

[P Wagland]

*sigh*

Nope. It still does not work for me....Build 2000121308 still shows exactly the
same results as the screenshot that I have given. This the linux installer
build. Could that make a difference? Are there any system libraries that might
be causing me problems?

It really is very frustrating that I appear to be the only one to see this
problem...any assistance that can be offered would be greatly appreciated!

Comment 10

[pnunn]

Reporter:
Just for fun, would you take a look at the page I have attached
with the browser has the bug? It is a very simplified page that only
uses one image, lijntop.gif. If you could attach a screen grab of
the page, it would good.

I'm afraid I haven't been able to reproduce the problem either...
we'll track it down.

-p

Comment 11

[pnunn]

Attachment: simplified test page, html

Comment 12

[pnunn]

Attachment: test image used in simplified test html

Comment 13

[P Wagland]

Attachment: this is a shot of 2000121208 failing with the simple test case

Comment 14

[P Wagland]

OK. Well the screenshot is now attached. It is still failing in exactly the same
way. (for me at least). I should note that I will be getting a new machine soon,
and so will be able to suck the source and build it. If it is an environmental
error, then this may well flush the problem. Mind you, there do not appear to be
any .so's imported that could cause this problem....

Comment 15

[pnunn]

Note: 
see notes supplied by mm on bug#55940. May be related.
-p

Comment 16

[pnunn]

Yippee. I can duplicate the problem on my linux build.
And the image request to image lib is asking for
an image width=2, height=62, whereas it should be asking for
an image width=1, height=32. I'll find out who is issuing the
bogus request.

Comment 17

[pnunn]

I'll take this off of Clayton's plate and find out
who is generating the incorrect dimensions.
-p

Comment 18

[pnunn]

Buster:
I dunno if this bug should go to you, but if not, would
you route it to the correct person?

It looks like the bug is somewhere in nsHTMLImageLoader.cpp in
nsHTMLImageLoader::GetDesiredSize(). And it is unix specific.
The images look fine on NT, but are incorrect on linux.. I have
not checked the display on other unixes.  ?? maybe a twips problem?

The problem also seems to relate to the calculations where only
one dimension is given and the other calculated. 

The dimensions are incorrect by the time the image request is issued
to the image library.
-pn

Comment 19

[P Wagland]

Hi all!

Success! With Build 2000123121 the screen appears (roughly) as it should be!

Thanks!

Comment 20

[Marc Attinasi]

I'm checking this out. It may work now, but I am nervous because AFAIK nothing
has changed, certainly not in the nsHTMLImageLoader...

Comment 21

[Marc Attinasi]

Nervous or not, it seems to be working correctly. I tested the URL and the
testcase on Linux (RedHat 6.2) and saw no problems. Marking WORKSFORME - I'm
sure if this reappears it will be reopened or rereported ;)

Comment 22

[Amarendra Hanumanula]

QA contact update