616010 - When previewing personas, the UI should not move

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Shawn Wilsher :sdwilsh]

When you preview a persona, the tab strip and toolbars move around.

Comment 1

[juan becerra [:juanb]]

I wasn't able to reproduce this problem with a clean profile nor with a vintage one. Previewing different personas rapidly makes me dizzy, but I didn't see the UI jump around.

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> I wasn't able to reproduce this problem with a clean profile nor with a vintage
> one. Previewing different personas rapidly makes me dizzy, but I didn't see the
> UI jump around.
I saw this on both 3.6 and 4.0 (3.6 had a new profile, but 4.0 did not).

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> I wasn't able to reproduce this problem with a clean profile nor with a vintage
> one. Previewing different personas rapidly makes me dizzy, but I didn't see the
> UI jump around.
Also, this may be windows only.  I tested on windows 7.

Comment 4

[Dietrich Ayala (:dietrich)]

Can we get confirmation on Win7?

Comment 5

[Johnathan Nightingale [:johnath]]

There was a minor version of this problem in 3.6, but it's worse now, and multi-platform. betaN+

Comment 6

[Kevin Brosnan]

Attachment: example of the issue

Made a short video of what I am seeing. On some Personas the whole browser looks to be moving by a few pixels.

Comment 7

[Frank Yan (:fryn)]

Starting work on this.

This bug occurs on at least Windows and OS X (just the add-ons bar for OS X).
Will investigate Linux soon.

Comment 8

[George Carstoiu]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110127 Firefox/4.0b11pre

Can confirm that the whole browser looks to be moving by a few pixels when switching between default theme and a persona. Between personas this effect is not present.

Comment 9

[(no longer active)]

Is there a good reason that this blocks betaN?  If not, it should be moved over to final+.

Comment 10

[Frank Yan (:fryn)]

(In reply to comment #9)
> Is there a good reason that this blocks betaN?  If not, it should be moved over
> to final+.

I think this should be final+ too. Fixing this bug only involves making small adjustments to browser/theme/* stylesheets. I've just been testing each platform and UI configuration, ensuring that widths, heights, paddings, borders, and margins are all consistent between non-personas and personas mode.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

If a patch appears and passes review, it has implicit a=beltzner

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 7 automatically changed from blocking2.0:final+ to blocking2.0:.x during the endgame of Firefox 4 for the following reasons:

 - it was marked as a soft blocking issue without a requirement for beta coverage

Comment 13

[Edo Karabas]

I think this is fixed by bug 570279.

Comment 14

[Frank Yan (:fryn)]

(In reply to Eddward from comment #13)
> I think this is fixed by bug 570279.

No, it wasn't. For example, the link URL preview bubble in the lower left moves when previewing a lightweight theme with the find bar open.

Comment 15

[u279076]

I'm unable to reproduce this in that latest Firefox Nightly. Please reopen if this is still an issue.