Don't set browser homepage in webrunner.js

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: matthew.gertner, Assigned: matthew.gertner)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
It turns out to be a bad idea to set the browser homepage in webrunner.js since it can get changed in all kinds of wacky circumstances (e.g. when a protocl URI is used). Better to set it only when webapp.ini is being parsed.
(Assignee)

Comment 1

8 years ago
Created attachment 494673 [details] [diff] [review]
Set homepage when webapp.ini is parsed
Attachment #494673 - Flags: review?(mark.finkle)
(Assignee)

Updated

8 years ago
Attachment #494673 - Attachment is patch: true
Attachment #494673 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 2

8 years ago
Created attachment 494674 [details] [diff] [review]
Set homepage when webapp.ini is parsed
Attachment #494673 - Attachment is obsolete: true
Attachment #494674 - Flags: review?(mark.finkle)
Attachment #494673 - Flags: review?(mark.finkle)
Attachment #494674 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

8 years ago
Sending        chrome/content/webrunner.js
Sending        common/modules/WebAppProperties.jsm
Transmitting file data ..
Committed revision 79460.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.