Closed Bug 616104 Opened 14 years ago Closed 14 years ago

Don't set browser homepage in webrunner.js

Categories

(Mozilla Labs :: Prism, defect)

Product:
Mozilla Labs
Component:
Prism
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: matthew.gertner, Assigned: matthew.gertner)

Details

Attachments

(1 file, 1 obsolete file)

Set homepage when webapp.ini is parsed
1.37 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
It turns out to be a bad idea to set the browser homepage in webrunner.js since it can get changed in all kinds of wacky circumstances (e.g. when a protocl URI is used). Better to set it only when webapp.ini is being parsed.

        Attachment #494673 -
        Flags: review?(mark.finkle)

    
  

        Attachment #494673 -
        Attachment is patch: true

        Attachment #494673 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  


  

        Attachment #494673 -
        Attachment is obsolete: true

        Attachment #494674 -
        Flags: review?(mark.finkle)

        Attachment #494673 -
        Flags: review?(mark.finkle)

        Attachment #494674 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
Sending        chrome/content/webrunner.js
Sending        common/modules/WebAppProperties.jsm
Transmitting file data ..
Committed revision 79460.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: