Widget and events docs need updating in light of widget API changes

RESOLVED FIXED in 1.0b1

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

unspecified
1.0b1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cherry-pick-1.0b1])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The widget doc still says events are passed to event listeners and its onMessage description is a little weird, and the Working with Events guide hasn't been updated for the event parameter removal and the image property removal.

These fixes require another beta 1 respin.
(Assignee)

Comment 1

8 years ago
Created attachment 494725 [details] [diff] [review]
patch
Attachment #494725 - Flags: review?(myk)
Comment on attachment 494725 [details] [diff] [review]
patch

Nice, r=myk.

But this reminds me that we have yet to resolve bug 593921, and there is some inconsistency in the way we call message handlers across the API set, with some APIs passing the message as the first argument, while this one passes the widget object.  I'll think about what to do here and then file followup bugs as needed.
Attachment #494725 - Flags: review?(myk) → review+
Blocks: 611250
(Assignee)

Comment 3

8 years ago
https://github.com/mozilla/addon-sdk/commit/8f4416a396634ae9cc114708787641c0c1e7280c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
Whiteboard: [cherry-pick-needed]
Target Milestone: 0.10 → 1.0b1
You need to log in before you can comment on or make changes to this bug.