Closed
Bug 616140
Opened 14 years ago
Closed 14 years ago
Widget and events docs need updating in light of widget API changes
Categories
(Add-on SDK Graveyard :: Documentation, defect)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [cherry-pick-1.0b1])
Attachments
(1 file)
|
3.96 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
The widget doc still says events are passed to event listeners and its onMessage description is a little weird, and the Working with Events guide hasn't been updated for the event parameter removal and the image property removal.
These fixes require another beta 1 respin.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #494725 -
Flags: review?(myk)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 494725 [details] [diff] [review]
patch
Nice, r=myk.
But this reminds me that we have yet to resolve bug 593921, and there is some inconsistency in the way we call message handlers across the API set, with some APIs passing the message as the first argument, while this one passes the widget object. I'll think about what to do here and then file followup bugs as needed.
Attachment #494725 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
|
|
||
Updated•14 years ago
|
Whiteboard: [cherry-pick-needed]
|
|
||
Comment 4•14 years ago
|
||
Whiteboard: [cherry-pick-needed] → [cherry-pick-1.0b1]
|
|
||
Updated•14 years ago
|
Target Milestone: 0.10 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•