tools/release/signing/tests.py fails in preproduction

RESOLVED FIXED

Status

Release Engineering
General
P5
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Assigned: salbiz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
python tests.py
 in dir /builds/buildbot/preproduction/slave/test-masters/tools/release/signing
...

.....F
======================================================================
FAIL: Test that the expected sort order is maintained with plain
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 147, in testSorting
    self.assertEquals(results, sorted_files)
AssertionError: ['unsigned/partner-repacks/chinapack-win32/win32/en-US/Firefox Setup 3.6.13.exe', 'unsigned/win32/en-US/Firefox Setup 3.6.13.exe', 'unsigned/update/win32/en-US/firefox-3.6.13.complete.mar', 'unsigned/win32/ar/Firefox Setup 3.6.13.exe', 'unsigned/update/win32/ar/firefox-3.6.13.complete.mar', 'unsigned/partner-repacks/google/win32/ar/Firefox Setup 3.6.13.exe'] != ['unsigned/win32/en-US/Firefox Setup 3.6.13.exe', 'unsigned/update/win32/en-US/firefox-3.6.13.complete.mar', 'unsigned/win32/ar/Firefox Setup 3.6.13.exe', 'unsigned/update/win32/ar/firefox-3.6.13.complete.mar', 'unsigned/partner-repacks/chinapack-win32/win32/en-US/Firefox Setup 3.6.13.exe', 'unsigned/partner-repacks/google/win32/ar/Firefox Setup 3.6.13.exe']

----------------------------------------------------------------------
Ran 6 tests in 0.004s

FAILED (failures=1)

Comment 1

8 years ago
internal, no priority, no assignee -> p5
Priority: -- → P5
(Assignee)

Comment 2

8 years ago
regression from signing refactoring patches (bug 613320), patch https://bugzilla.mozilla.org/attachment.cgi?id=492007 makes unit tests pass, but needs to be given a full run through on keystage as it risks breaking signing ordering.
Assignee: nobody → salbiz
Status: NEW → ASSIGNED
(Assignee)

Comment 3

8 years ago
Created attachment 499539 [details] [diff] [review]
use correct sort order

Tested in my latest staging run with a full set of locales and repacks. Passes the unit tests as well, so preproduction failure will go away.
Attachment #499539 - Flags: review?(bhearsum)
Attachment #499539 - Flags: review?(bhearsum) → review+
Comment on attachment 499539 [details] [diff] [review]
use correct sort order

changeset:   1922:b46ff8249918
Attachment #499539 - Flags: checked-in+
Should be all done here now.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

8 years ago
Great. I removed flunkOnFailure=False from the corresponding preproduction step, so builds will become red in the future on failure.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.