Parameter type of panel.show needs to be one word

RESOLVED FIXED in 1.0b1

Status

Product:
Add-on SDK
Component:
Documentation
Status:
RESOLVED FIXED
Reported:
8 years ago
Modified:
8 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Version:
unspecified
Target:
1.0b1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cherry-pick-1.0b1])

Attachments

(1 attachment)

patch
533 bytes, patch
myk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
8 years ago 
Our doc parser can't handle multi-word types, so if you view the panel doc in a browser you'll see that panel.show's parameter looks messed up.  My fault for not visually testing this when I changed it.
(Assignee)

Comment 1

•
8 years ago 
Created attachment 494739 [details] [diff] [review]
patch
Attachment #494739 - Flags: review?(myk)

Comment 2

•
8 years ago 
Comment on attachment 494739 [details] [diff] [review]
patch

Aha! r+a=myk
Attachment #494739 - Flags: review?(myk) → review+
(Assignee)

Comment 3

•
8 years ago 
https://github.com/mozilla/addon-sdk/commit/bca695230c78e0dd2d56fdc308055366dfd524df

https://github.com/mozilla/addon-sdk/commit/997f3a8ff2cc0ec2a4658c0681ee041df53dea0b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
Whiteboard: [cherry-pick-wanted]
Target Milestone: 0.10 → 1.0b1
You need to log in before you can comment on or make changes to this bug.