Closed
Bug 616168
Opened 15 years ago
Closed 15 years ago
Parameter type of panel.show needs to be one word
Categories
(Add-on SDK Graveyard :: Documentation, defect)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: adw, Assigned: adw)
Details
(Whiteboard: [cherry-pick-1.0b1])
Attachments
(1 file)
|
533 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Our doc parser can't handle multi-word types, so if you view the panel doc in a browser you'll see that panel.show's parameter looks messed up. My fault for not visually testing this when I changed it.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #494739 -
Flags: review?(myk)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 494739 [details] [diff] [review]
patch
Aha! r+a=myk
Attachment #494739 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/bca695230c78e0dd2d56fdc308055366dfd524df
https://github.com/mozilla/addon-sdk/commit/997f3a8ff2cc0ec2a4658c0681ee041df53dea0b
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
|
|
||
Updated•15 years ago
|
Whiteboard: [cherry-pick-wanted]
|
|
||
Comment 4•15 years ago
|
||
Whiteboard: [cherry-pick-wanted] → [cherry-pick-1.0b1]
|
|
||
Updated•14 years ago
|
Target Milestone: 0.10 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•