616179 - Persona not displayed after pref sync cleanup

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Teodosia Pop]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre

After sync, if a persona is used, it's shown as changed to the correct persona in Add-ons Manager, but FF doesn't display it, not even on restart. 

Reproducible: Always

Steps to Reproduce:
1.Install a persona on one of the computers.
2.Sync the computers
Actual Results:  
The synced persona is not displayed, but it appears in Add-ons Manager.

Expected Results:  
FF should display the persona.

Comment 1

[Tracy Walker [:tracy]]

This is a regression. I also see it on XP and Mac minefield nightly builds.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Had forgotton to update the LTM code paths. They wouldn't show up in tests or logs since they're try-catch'ed for Firefox 3.5 compat. Also: yay for shoddy test coverage.

Tracy confirmed that this patch fixes the problem.

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/fx-sync/rev/37150bc0bf62

Comment 4

[Tracy Walker [:tracy]]

Verified with minefield nightly of 20101203