616230 - Submit feedback button is enabled when users go past max character limit

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Aakash Desai [:aakashd]]

Steps to Reproduce:
1. Go to input.stage.mozilla.com/happy or input.stage.mozilla.com/sad
2. Type in greater than 140 characters
3. Click on the submit feedback button

Actual Results:
Submit feedback button is enabled even though they can't submit the message.

Expected Results:
Submit feedback button should be disabled when they type past the allowable amount of characters. A user shouldn't need to click on the button in order to find out they cannot submit feedback unless their message is less than the allowable limit.

Comment 1

[Fred Wenzel [:wenzel]]

Ryan, will you add that to the JS?

Comment 2

[Fred Wenzel [:wenzel]]

This is a UX win, but not a blocker for 2.1, so I am pushing it to 2.2 to give Ryan some more time.

Comment 3

[Fred Wenzel [:wenzel]]

Moving all 2.2 bugs to 3.0, as their code freezes would most likely coincide.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Disabling submit feedback button if the user goes over the character limit.

==

https://github.com/fwenzel/reporter/commit/5b22f3

Comment 5

[Rebecca Billings [:rbillings]]

Verified submit button is disabled until the user as zero or a positive # of characters remaining