616382 - PGO fails when building from toplevel source directory using pymake

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

For the last week, PGO is not working when I build with pymake.

Possibly related, I see the following warning quite a bit:
warning C4964: No optimization options were specified; profile info will not be collected

Maybe related to the native cl landing?

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Backing out http://hg.mozilla.org/mozilla-central/rev/0e9ba7c029e3 doesn't seem to have made any difference.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

It's dying when running pymake from the toplevel dir instead of the objdir.

WORKS:
cd objdir-fx
python -OO ../build/pymake/make.py -f ../client.mk profiledbuild

FAILS:
python -OO build/pymake/make.py -f client.mk profiledbuild

Build ends with a bunch of junk like the below during the packaging phase (pre-PGO omnijar stuff I guess)
c:\mozbuild\mozilla-central\config\rules.mk:751:0: command 'c:/mozbuild/python/python.exe c:/mozbuild/mozilla-central/build/pymake/pymake/../make.py libs' failed, return code 2
c:\mozbuild\mozilla-central\browser\build.mk:65:0: command 'c:/mozbuild/python/python.exe c:/mozbuild/mozilla-central/build/pymake/pymake/../make.py -C browser/installer' failed, return code 2
c:\mozbuild\mozilla-central\client.mk:211:0: command 'c:/mozbuild/python/python.exe c:/mozbuild/mozilla-central/build/pymake/pymake/../make.py -C c:/mozbuild/mozilla-central/objdir-fx package' failed, return code 2

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ah, this has probably never worked then.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Easy enough to work around, anyway!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This issue is alive and well and prevents PGO builds from working with pymake.

Comment 6

[(not currently active) Ted Mielczarek]

I did a couple of PGO builds with pymake -f client.mk last week without problems. Have you tried a more recent source? I think this got fixed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

It does indeed now!