If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make an exception for {key +}

RESOLVED WONTFIX

Status

support.mozilla.org
Knowledge Base Software
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: Cww, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
I love the new {key Ctrl+K} syntax.  But if we want the + key (as in zoom) we get stuck with some broken markup no matter how we write it.  Obviously {key Ctrl + +} would be awesome but I think if we just have an exception for {key +}, we could express anything even if it means {key Ctrl} + {key +} and it's a more logical workaround.
What if we space-delimited them instead? I'm not sure that's an option but then + would work like anything else.

Comment 2

7 years ago
What about this solution: {key <no wiki>+</no wiki>}?
I didn't test it but I think it could work.
(In reply to comment #2)
> What about this solution: {key <no wiki>+</no wiki>}?
> I didn't test it but I think it could work.

That's unlikely to work off the bat. Our custom extensions to MediaWiki syntax (like {key }) don't obey the <nowiki> tag.

On the other hand, {key &#43;} should work.


(In reply to comment #1)
> What if we space-delimited them instead? I'm not sure that's an option but then
> + would work like anything else.

If I actually think this through it's a terrible idea, since we'd be breaking everything that uses it now.

Comment 4

7 years ago
(In reply to comment #3)
> (In reply to comment #2)
> > What about this solution: {key <no wiki>+</no wiki>}?
> > I didn't test it but I think it could work.
> 
> That's unlikely to work off the bat. Our custom extensions to MediaWiki syntax
> (like {key }) don't obey the <nowiki> tag.
> 
> On the other hand, {key &#43;} should work.

That looks like a perfectly reasonable workaround for this. Can anyone confirm if this works?
Just tested it on master and {key Ctrl+&#43;} works as expected, i.e.: well.

Comment 6

7 years ago
Then I suggest WONTFIXing this. Cheng, any objections?
(Reporter)

Comment 7

7 years ago
Yeah, I guess... I'm sad about having to go through all 40 keyboard shortcuts articles and fixing this though.

Comment 8

7 years ago
Any way we can script that update instead? Seems faster...
(In reply to comment #8)
> Any way we can script that update instead? Seems faster...

I'd rather take the time we'd spend writing, testing, and deploying that fix and just help change it.
Just talked with Cheng and with him+localizers+a little extra help we'll just make the changes by hand.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.