616608 - Pass the rest of webgl-specific.html test (sections 6.4, 6.5, 6.7 of the spec)

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: implement section 6.7 on depthRange

First patch: pass section 6.7 on depthRange.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: implement section 6.5 on separate parameters

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: formally support COLORSPACE_CONVERSION (just accessors)

Just doing this formally, to get this test page green.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 495111 [details] [diff] [review]
implement section 6.5 on separate parameters

>+    if (ref != mStencilRef || mask != mStencilValueMask)
>+        return ErrorInvalidOperation("stencilFuncSeparate: WebGL doesn't currently allow specifying "
>+                                     "different values for front and back, i.e. this function is currently useless.");

Let's not get snarky here :-)  "WebGL requires the same values for both front and back stencil mask" or something.  Also, this function can still work fine, if the specified face is GL_FRONT_AND_BACK, in which case it should work the same as glStencilMask.

> NS_IMETHODIMP
> WebGLContext::StencilMaskSeparate(WebGLenum face, WebGLuint mask)
> {
>     if (!ValidateFaceEnum(face, "stencilMaskSeparate: face"))
>         return NS_OK;
> 
>+    if (mask != mStencilWriteMask)
>+        return ErrorInvalidOperation("stencilMaskSeparate: WebGL doesn't currently allow specifying "
>+                                     "different values for front and back, i.e. this function is currently useless.");
>+

Same thing here for face == FRONT_AND_BACK; the function should set the write mask and mStencilWriteMask if face == FRONT_AND_BACK.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: implement section 6.5 on separate parameters

OK, I had overlooked FRONT_AND_BACK in the logic.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: implement section 6.5 on separate parameters

Forgot to update the values.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 495128 [details] [diff] [review]
implement section 6.5 on separate parameters

thanks :)

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/0166ebdffad8
http://hg.mozilla.org/mozilla-central/rev/48dfe6fbd6b4
http://hg.mozilla.org/mozilla-central/rev/2b4e8d17d7b7