tree collapse widgets don't work reliably

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Gavin, Assigned: wenzel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Trying to collapse someone in the tree.php view doesn't really work. Sometimes they get collapsed, but collapsing anyone else, or interacting with the tree in any ways uncollapses them. Tested both 3.6 and trunk builds.
(Assignee)

Updated

7 years ago
Duplicate of this bug: 694412
Since we have nearly 600 employees and this is the primary (currently only?) method of looking up employees and org chart, is it possible for us to fix this item?

I realize there are lots of other priorities, but this would be very nice to have resolved.
In tree-view.js:

45 BehaviorManager.register("treeNodeToggling", function(e) {
46   !e.element().match("a") && $(this).toggleTree();
47   Tree.doNotFilter = true;
48   Tree.select(this);
49   e.stop();
50 }.toBehavior(new Selector("div li.hr-node"), "click")); 

Line 48, Tree.select(this) is what is changing the search filter when a tree is collapsed or expanded. Removing that should allow you to collapse and expand freely, although there will still be the lingering issue of collapsing and expanding happening whenever you select a name.
(Assignee)

Comment 4

7 years ago
Thanks mkelly! That almost works: If we remove the select(this) altogether, then clicking on names in the list won't work anymore. However, I can change it so it will only change the search when you click a name, not an arrow.

In addition, I'll remove the function that always expands the entire tree whenever you click on a name anywhere. This has edge cases, but I think it's much better than what we have now.
(Assignee)

Updated

7 years ago
Assignee: nobody → fwenzel
(Assignee)

Comment 5

7 years ago
Fixed in r100299. I'll file an IT bug to get this pushed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 720656
You need to log in before you can comment on or make changes to this bug.